You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "atppp (JIRA)" <ji...@apache.org> on 2009/04/28 19:35:30 UTC

[jira] Updated: (HBASE-1347) HTable.incrementColumnValue does not take negative 'amount'

     [ https://issues.apache.org/jira/browse/HBASE-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

atppp updated HBASE-1347:
-------------------------

    Attachment: HBASE-1347-quick-fix.patch

> HTable.incrementColumnValue does not take negative 'amount'
> -----------------------------------------------------------
>
>                 Key: HBASE-1347
>                 URL: https://issues.apache.org/jira/browse/HBASE-1347
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.19.1
>         Environment: Ubuntu 8.10
>            Reporter: atppp
>            Priority: Minor
>             Fix For: 0.19.2
>
>         Attachments: HBASE-1347-quick-fix.patch
>
>
> Apparently HRegion.binaryIncrement() assumes argument 'amount' is always positive. It would be nice to support decrement operation. In my application, a counter can go both up and down.
> Quick fix is
>   public byte [] binaryIncrement(byte [] value, long amount) {
>     return Bytes.toBytes(Bytes.toLong(value) + amount);
>   } 
> but it is 2x~3x slower than current implementation for small positive 'amount' value. I have not yet found a good implementation to support negative 'amount' argument, AND match the speed of current implementation. Anyway, I just want to throw this out there and see if anybody is interested in negative 'amount' support. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.