[GitHub] GabrielBrascher commented on issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console

[GitBox <gi...@apache.org>]

GabrielBrascher commented on issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console
URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-447927256
 
 
   @DennisKonrad the PR is not blocked because of coding style. The author simply did not provide a technical reason to leave it as is. The problem here is also not about function naming. The issue here goes beyond that, and it has to do with code quality. ACS project has been suffering for years because of duplicated and convoluted code (bad practices that were implemented along the years). I only started a discussion regarding technical problems I found in this PR.
   
   Although I disagree with his approach, I did not block this PR (I do not even have powers to do that). The problem here is that the author did not care enough to provide a reasonable answer to maintain the duplicated code, or to reduce the code duplication, document it and create unit-tests for the newly added block of code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services