[GitHub] [hbase] YutSean commented on a change in pull request #3066: HBASE-25677 Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load

[GitBox <gi...@apache.org>]

YutSean commented on a change in pull request #3066:
URL: https://github.com/apache/hbase/pull/3066#discussion_r597486504



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -3053,21 +3053,22 @@ private void scan(HBaseRpcController controller, ScanRequest request, RegionScan
           builder.setScanMetrics(metricBuilder.build());
         }
       }
+    } finally {
+      region.closeRegionOperation();
+      // Update serverside metrics, even on error.
       long end = EnvironmentEdgeManager.currentTime();
       long responseCellSize = context != null ? context.getResponseCellSize() : 0;
       region.getMetrics().updateScanTime(end - before);
       if (regionServer.metricsRegionServer != null) {
-        regionServer.metricsRegionServer.updateScanSize(
-            region.getTableDesc().getTableName(), responseCellSize);
-        regionServer.metricsRegionServer.updateScanTime(
-            region.getTableDesc().getTableName(), end - before);
+        regionServer.metricsRegionServer.updateScanSize(region.getTableDesc().getTableName(), responseCellSize);
+        regionServer.metricsRegionServer.updateScanTime(region.getTableDesc().getTableName(), end - before);
+        regionServer.metricsRegionServer
+          .updateReadQueryMeter(region.getRegionInfo().getTable(), numOfNextRawCalls);
+      }
+      // coprocessor postNext hook
+      if (region.getCoprocessorHost() != null) {

Review comment:
       Right, branch-2/master don't have this change yet.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org