[superset] 01/01: chore(security): Make get_database_perm/get_dataset_perm return optional

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch john-bodley--security-perm-return-optional
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 2797a63f4d48588abc1506b7be6f8e4a4150bacc
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Fri May 12 09:25:38 2023 -0700

    chore(security): Make get_database_perm/get_dataset_perm return optional
---
 superset/security/manager.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/superset/security/manager.py b/superset/security/manager.py
index c54fdac87a..d75f15a3cd 100644
--- a/superset/security/manager.py
+++ b/superset/security/manager.py
@@ -320,11 +320,15 @@ class SupersetSecurityManager(  # pylint: disable=too-many-public-methods
         return None
 
     @staticmethod
-    def get_database_perm(database_id: int, database_name: str) -> str:
+    def get_database_perm(database_id: int, database_name: str) -> Optional[str]:
         return f"[{database_name}].(id:{database_id})"
 
     @staticmethod
-    def get_dataset_perm(dataset_id: int, dataset_name: str, database_name: str) -> str:
+    def get_dataset_perm(
+        dataset_id: int,
+        dataset_name: str,
+        database_name: str,
+    ) -> Optional[str]:
         return f"[{database_name}].[{dataset_name}](id:{dataset_id})"
 
     def unpack_database_and_schema(  # pylint: disable=no-self-use