You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/20 09:40:14 UTC

[GitHub] [spark] weixiuli commented on pull request #36279: [SPARK-38965][SHUFFLE]Retry transfer blocks for exceptions listed in the error handler

weixiuli commented on PR #36279:
URL: https://github.com/apache/spark/pull/36279#issuecomment-1103712254

   
   Good catching ! 
    It necessary to  distinguish the IOException and the `errorHandler.shouldRetryError`, the `errorHandler.shouldRetryError ` has two cases need to  retry, one is this PR  described `BLOCK_APPEND_COLLISION_MSG_SUFFIX` for  pushing, and other is  `STALE_SHUFFLE_BLOCK_FETCH` for fetching . Please add  some unittests for them. 
   also cc @otterc @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org