[jira] [Commented] (CAMEL-8394) camel-docker - DockerConfiguration should not keep client state

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345148#comment-14345148 ] 

ASF GitHub Bot commented on CAMEL-8394:
---------------------------------------

Github user sabre1041 closed the pull request at:

    https://github.com/apache/camel/pull/409


> camel-docker - DockerConfiguration should not keep client state
> ---------------------------------------------------------------
>
>                 Key: CAMEL-8394
>                 URL: https://issues.apache.org/jira/browse/CAMEL-8394
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-docker
>    Affects Versions: 2.15.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.15.0
>
>
> The configuration classes should be pure configuration, eg for users to configure options.
> Any state such as client in use et all should be stored on endpoint or component.
> eg move the options from DockerClientProfile to DockerConfiguration so there is only 1 class.
> And move the map with DockerClient to the component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)