You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/03/21 20:30:55 UTC

[PR] [SPARK-56130] Make `values.schema.json` up-to-date [spark-kubernetes-operator]

dongjoon-hyun opened a new pull request, #570:
URL: https://github.com/apache/spark-kubernetes-operator/pull/570

   ### What changes were proposed in this pull request?
   
   This PR adds missing schema definitions to `values.schema.json` to ensure it covers all values defined in `values.yaml` and referenced by Helm templates.
   
   The following items were added:
   - `readinessProbe` section under `probes` (with `failureThreshold`, `periodSeconds`, `timeoutSeconds`)
   - `initialDelaySeconds` and `timeoutSeconds` properties to `startupProbe`
   - `metrics` section under `operatorContainer` (with `port`)
   - `sparkClusterSentinel` section under `workloadResources`
   - `nameOverride` and `fullnameOverride` top-level properties
   - `sparkClusterSentinel` to the `workloadResources.required` array
   
   ### Why are the changes needed?
   
   The `values.schema.json` was incomplete — it did not cover all values defined in `values.yaml` and used by Helm templates. This could lead to schema validation missing invalid configurations or failing to document available options for users.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Verified with `helm lint` and JSON validity check.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-6)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56130] Make `values.schema.json` up-to-date [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.

dongjoon-hyun commented on PR #570:
URL: https://github.com/apache/spark-kubernetes-operator/pull/570#issuecomment-4111932795

   Thank you so much, @peter-toth !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56130] Make `values.schema.json` up-to-date [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.

dongjoon-hyun commented on PR #570:
URL: https://github.com/apache/spark-kubernetes-operator/pull/570#issuecomment-4111651590

   Could you review this PR, @peter-toth ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56130] Make `values.schema.json` up-to-date [spark-kubernetes-operator]

Posted by "peter-toth (via GitHub)" <gi...@apache.org>.

peter-toth commented on PR #570:
URL: https://github.com/apache/spark-kubernetes-operator/pull/570#issuecomment-4111657673

   Oh I missed this, checking...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56130] Make `values.schema.json` up-to-date [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.

dongjoon-hyun commented on PR #570:
URL: https://github.com/apache/spark-kubernetes-operator/pull/570#issuecomment-4111938193

   Merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56130] Make `values.schema.json` up-to-date [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.

dongjoon-hyun commented on PR #570:
URL: https://github.com/apache/spark-kubernetes-operator/pull/570#issuecomment-4111667532

   Thank you for checking this, @peter-toth ~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-56130] Make `values.schema.json` up-to-date [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.

dongjoon-hyun closed pull request #570: [SPARK-56130] Make `values.schema.json` up-to-date
URL: https://github.com/apache/spark-kubernetes-operator/pull/570


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org