You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/10 01:16:00 UTC

[jira] [Commented] (BEAM-3081) Our findbugs config does not actually use Nullable annotations effectively

    [ https://issues.apache.org/jira/browse/BEAM-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246859#comment-16246859 ] 

ASF GitHub Bot commented on BEAM-3081:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/4058


> Our findbugs config does not actually use Nullable annotations effectively
> --------------------------------------------------------------------------
>
>                 Key: BEAM-3081
>                 URL: https://issues.apache.org/jira/browse/BEAM-3081
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>
> We use {{@Nullable}} annotations mostly appropriately, but in fact our findbugs config was not delivering value based on these annotations, because it does not default to {{@NonNull}}. We can and should set this default.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)