You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by br...@xbc.nu on 2002/06/03 09:19:55 UTC

Neon woes

Neon 0.21.0 doesn't even compile on Windows.
I'd like to revert the upgrade until it does.
Is there any really strong reason we should be using
0.21.0 (except for the mod-deflate stuff)?

    Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

RE: Neon woes

Posted by Sander Striker <st...@apache.org>.
> From: Joe Orton [mailto:joe@manyfish.co.uk]
> Sent: 03 June 2002 13:28

> On Mon, Jun 03, 2002 at 11:35:54AM +0200, Sander Striker wrote:
>>> From: brane@xbc.nu [mailto:brane@xbc.nu]
>>> Sent: 03 June 2002 11:20
>>> I'd like to revert the upgrade until it does.
>>> Is there any really strong reason we should be using
>>> 0.21.0 (except for the mod-deflate stuff)?
>> 
>> No, not really, apart from it being the latest neon release.
>> You need two patches to neon to get it to work on windows.
>> One I sent to the list and one Joe sent to the list.
> 
> Does the ssize_t patch I posted work then? (I can't test it myself)

Yes, it works.  Just tested.

>> There is another problem that has rissen its ugly head:
>> neon now requires zlib, otherwise svn will fail on the
>> deflate stuff.  I thought that was supposed to be
>> transparent, but apparently it isn't (yet?).
> 
> It only works when zlib is *not* used, so the passthrough code is
> working fine. neon was giving the "truncated response" decompress error
> if the acceptance callback decided not to accept a response (which would
> always happen in ra_dav with the error_accepter for 2xx responses).

Ah...

> A fix is below - I can do a new neon release once someone has confirmed
> that the ssize_t patch works. (Does SVN even work on a deflate-enabled
> server without this change?)

Oddly enough, it seemed to work.
 
> --- ne_compress.c	19 May 2002 14:38:15 -0000	1.15
> +++ ne_compress.c	3 Jun 2002 10:37:02 -0000	1.16
> @@ -348,6 +348,7 @@
>  	free(ctx->enchdr);
>  
>      switch (ctx->state) {
> +    case NE_Z_BEFORE_DATA:
>      case NE_Z_PASSTHROUGH:
>      case NE_Z_FINISHED:
>  	ret = NE_OK;


Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Neon woes

Posted by Joe Orton <jo...@manyfish.co.uk>.
On Mon, Jun 03, 2002 at 11:35:54AM +0200, Sander Striker wrote:
> > From: brane@xbc.nu [mailto:brane@xbc.nu]
> > Sent: 03 June 2002 11:20
> > I'd like to revert the upgrade until it does.
> > Is there any really strong reason we should be using
> > 0.21.0 (except for the mod-deflate stuff)?
> 
> No, not really, apart from it being the latest neon release.
> You need two patches to neon to get it to work on windows.
> One I sent to the list and one Joe sent to the list.

Does the ssize_t patch I posted work then? (I can't test it myself)

> There is another problem that has rissen its ugly head:
> neon now requires zlib, otherwise svn will fail on the
> deflate stuff.  I thought that was supposed to be
> transparent, but apparently it isn't (yet?).

It only works when zlib is *not* used, so the passthrough code is
working fine. neon was giving the "truncated response" decompress error
if the acceptance callback decided not to accept a response (which would
always happen in ra_dav with the error_accepter for 2xx responses).

A fix is below - I can do a new neon release once someone has confirmed
that the ssize_t patch works. (Does SVN even work on a deflate-enabled
server without this change?)

--- ne_compress.c	19 May 2002 14:38:15 -0000	1.15
+++ ne_compress.c	3 Jun 2002 10:37:02 -0000	1.16
@@ -348,6 +348,7 @@
 	free(ctx->enchdr);
 
     switch (ctx->state) {
+    case NE_Z_BEFORE_DATA:
     case NE_Z_PASSTHROUGH:
     case NE_Z_FINISHED:
 	ret = NE_OK;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

RE: Neon woes

Posted by Sander Striker <st...@apache.org>.
> From: brane@xbc.nu [mailto:brane@xbc.nu]
> Sent: 03 June 2002 11:20

> Neon 0.21.0 doesn't even compile on Windows.

I ran into the same problem after committing the
neon update, when I wanted to test on my windows
box.  Not really wanting to revert I eventually
got it to work on windows.  It's quite straightforward,
albeit not out of the box.

> I'd like to revert the upgrade until it does.
> Is there any really strong reason we should be using
> 0.21.0 (except for the mod-deflate stuff)?

No, not really, apart from it being the latest neon release.
You need two patches to neon to get it to work on windows.
One I sent to the list and one Joe sent to the list.

There is another problem that has rissen its ugly head:
neon now requires zlib, otherwise svn will fail on the
deflate stuff.  I thought that was supposed to be
transparent, but apparently it isn't (yet?).
 
>     Brane

Sander



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org