[GitHub] [helix] rahulrane50 commented on pull request #2478: Add hashCode() to AssignableReplica and fix logic in hash-based collection

["rahulrane50 (via GitHub)" <gi...@apache.org>]

rahulrane50 commented on PR #2478:
URL: https://github.com/apache/helix/pull/2478#issuecomment-1540905841

   @qqu0127 just 2 cents about performance, the performance hit you will see only for huge lists (as mentioned by jiajun for large clusters). In the stackoverflow link you added in prev comment see 5th answer it talks about that. Unless it's really required or have any benefits to back with benchmarking results, it could be risky to do it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org