You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sruthakeerthikotla <gi...@git.apache.org> on 2017/05/24 12:53:17 UTC
[GitHub] cordova-node-xcode pull request #2: Update pbxProject.js
GitHub user sruthakeerthikotla opened a pull request:
https://github.com/apache/cordova-node-xcode/pull/2
Update pbxProject.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sruthakeerthikotla/cordova-node-xcode develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-node-xcode/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit 5ca323c847fd6917b4dfb05abbd05903df78e19e
Author: sruthakeerthikotla <sr...@gmail.com>
Date: 2017-05-24T12:50:35Z
Update pbxProject.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-node-xcode issue #2: CB-12844 Update pbxProject.js
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-node-xcode/pull/2
Hey @sruthakeerthikotla!
Could you add a test to the pr?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-node-xcode pull request #2: CB-12844 Update pbxProject.js
Posted by sruthakeerthikotla <gi...@git.apache.org>.
Github user sruthakeerthikotla commented on a diff in the pull request:
https://github.com/apache/cordova-node-xcode/pull/2#discussion_r118695621
--- Diff: lib/pbxProject.js ---
@@ -1546,7 +1546,7 @@ function pbxShellScriptBuildPhaseObj(obj, options, phaseName) {
obj.inputPaths = options.inputPaths || [];
obj.outputPaths = options.outputPaths || [];
obj.shellPath = options.shellPath;
- obj.shellScript = '"' + options.shellScript.replace(/"/g, '\\"') + '"';
+ obj.shellScript = '"' + options.shellScript.replace(/\\/g, '\\\\') + '"';
--- End diff --
Looks like it was overwritten incorrectly. Updated the pull request with the replacing of " as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-node-xcode pull request #2: CB-12844 Update pbxProject.js
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-node-xcode/pull/2#discussion_r118257164
--- Diff: lib/pbxProject.js ---
@@ -1546,7 +1546,7 @@ function pbxShellScriptBuildPhaseObj(obj, options, phaseName) {
obj.inputPaths = options.inputPaths || [];
obj.outputPaths = options.outputPaths || [];
obj.shellPath = options.shellPath;
- obj.shellScript = '"' + options.shellScript.replace(/"/g, '\\"') + '"';
+ obj.shellScript = '"' + options.shellScript.replace(/\\/g, '\\\\') + '"';
--- End diff --
Doing this you remove the escaping of `"`, I should have both, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org