You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "zeotuan (via GitHub)" <gi...@apache.org> on 2023/09/07 03:12:28 UTC
[GitHub] [airflow] zeotuan opened a new pull request, #34153: Add K8sPodOperators progress_callback
zeotuan opened a new pull request, #34153:
URL: https://github.com/apache/airflow/pull/34153
closes: #31745
add progress_callback to allow custom behavior based on job logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on a diff in pull request #34153: Add `progress_callback` parameter to `KubernetesPodOperator`
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #34153:
URL: https://github.com/apache/airflow/pull/34153#discussion_r1320209525
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -413,6 +416,9 @@ def consume_logs(
for raw_line in logs:
line = raw_line.decode("utf-8", errors="backslashreplace")
line_timestamp, message = self.parse_log_line(line)
+ if self._progress_callback:
+ print(line)
Review Comment:
why do you need to print the line? I think you should remove this line:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #34153: Add `progress_callback` parameter to `KubernetesPodOperator`
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34153:
URL: https://github.com/apache/airflow/pull/34153#issuecomment-1712568740
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #34153: Add `progress_callback` parameter to `KubernetesPodOperator`
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #34153:
URL: https://github.com/apache/airflow/pull/34153#discussion_r1319430678
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -328,6 +328,7 @@ def __init__(
is_delete_operator_pod: None | bool = None,
termination_message_policy: str = "File",
active_deadline_seconds: int | None = None,
+ progress_callback: Callable[[str], None] | None = None,
Review Comment:
Please add this parameter to the class doc string description
`:param progress_callback: ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #34153: Add K8sPodOperators progress_callback
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34153:
URL: https://github.com/apache/airflow/pull/34153#issuecomment-1710596101
I recommend installing pre-commit and rebasing/amending the change - it will then fix the static checks for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zeotuan closed pull request #34153: Add K8sPodOperators progress_callback
Posted by "zeotuan (via GitHub)" <gi...@apache.org>.
zeotuan closed pull request #34153: Add K8sPodOperators progress_callback
URL: https://github.com/apache/airflow/pull/34153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #34153: Add K8sPodOperators progress_callback
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34153:
URL: https://github.com/apache/airflow/pull/34153#issuecomment-1709413165
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #34153: Add `progress_callback` parameter to `KubernetesPodOperator`
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #34153:
URL: https://github.com/apache/airflow/pull/34153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org