You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/23 22:55:17 UTC
[GitHub] [incubator-tvm] tkonolige opened a new pull request #6131: [FIX] Fixes #6096
tkonolige opened a new pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131
Clear the compile cache between module builds so that schedule changes will have an effect. Also, clear the warning cache so that schedule changes properly list untuned ops.
Note: this makes `CompileEngine` a mutable global variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
jwfromm commented on a change in pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#discussion_r460172911
##########
File path: src/relay/backend/compile_engine.cc
##########
@@ -770,7 +770,7 @@ class CompileEngineImpl : public CompileEngineNode {
};
/*! \brief The global compile engine */
-const CompileEngine& CompileEngine::Global() {
+CompileEngine& CompileEngine::Global() {
Review comment:
What's the reason for dropping the `const` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#discussion_r460174049
##########
File path: src/relay/backend/compile_engine.cc
##########
@@ -770,7 +770,7 @@ class CompileEngineImpl : public CompileEngineNode {
};
/*! \brief The global compile engine */
-const CompileEngine& CompileEngine::Global() {
+CompileEngine& CompileEngine::Global() {
Review comment:
Clearing the cache mutates the `CompileEngine`, so in order to clear the cache after each build we need to modify the global state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jwfromm commented on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-664595130
@merrymercy, any idea why this change is triggering CI errors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-665960679
One of the failing tests is `tests/python/relay/test_external_runtime.py`. You can play around with it to try and debug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-666460584
Yeah, one quick thing I can do is to retire the example runtime since we have a real json runtime now. This example is not really use any more. I can send a PR later. cc @comaniac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6131: [FIX] Fixes #6096
Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#discussion_r459777668
##########
File path: python/tvm/autotvm/task/relay_integration.py
##########
@@ -140,6 +140,11 @@ def extract_from_multiple_program(mods, params, target, target_host=None, ops=No
build_thread.start()
build_thread.join()
relay.backend.compile_engine.get().clear()
+ # Clear the warning message cache in FallbackContext
+ from tvm.autotvm.task.dispatcher import DispatchContext, FallbackContext
Review comment:
Could we move the import to the top of this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy commented on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
merrymercy commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-664641549
@tkonolige Can you reproduce the error locally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-667320482
@merrymercy @tqchen We can merge this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6131: [FIX] Fixes #6096
Posted by GitBox <gi...@apache.org>.
jroesch commented on a change in pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#discussion_r459773263
##########
File path: src/relay/backend/build_module.cc
##########
@@ -225,6 +226,8 @@ class RelayBuildModule : public runtime::ModuleNode {
targets_ = targets;
target_host_ = target_host;
BuildRelay(mod, params_);
+ // Clear compile engine so that tuning schedules can be changed between runs.
Review comment:
maybe put a back pointer to the issue so people can read more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-666124551
I pinged @zhiics since he is the owner afaik of this code, he said he would look at it tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy edited a comment on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
merrymercy edited a comment on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-664641549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jwfromm commented on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-663634086
@tkonolige, looks like the CI got aborted, can you rebase and push to trigger a new run?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tkonolige commented on pull request #6131: [FIX] Clear relay cache after every build & Clear warning message cache after autotvm task extraction
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #6131:
URL: https://github.com/apache/incubator-tvm/pull/6131#issuecomment-664655554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org