You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/19 11:42:51 UTC

[GitHub] [ozone] bharatviswa504 opened a new pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

bharatviswa504 opened a new pull request #2432:
URL: https://github.com/apache/ozone/pull/2432


   ## What changes were proposed in this pull request?
   
   Use latestVersion config for createKey/createFile.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-5393
   
   ## How was this patch tested?
   
   Existing tests. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 edited a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 edited a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895934845


   >  can you add a test in TestOmBlockVersioning for this create case?
   
   I have added test in new classes, TestOmBlockVersioning uses old write code path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi edited a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi edited a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-897299101


   > What returns null? I have not understood that part, care to explain more.
   >
   I means aws s3 put object doesn't return object version if buckt versioning is disabled. 
   
   > I am okay to do change with out using flag, but I think we can remove this every where if it is not required in read path also, as get by default returns latest version. So, this can be addressed in new Jira
   >
   Yes, we can do it in a seperate JIRA.  
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi merged pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi merged pull request #2432:
URL: https://github.com/apache/ozone/pull/2432


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895688215


   Hey @bharatviswa504 , can you add a test in TestOmBlockVersioning for this create case?  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895927319


   I have added the test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895764452


   I revisted aws s3 documents, it seems that aws put object API only returns the latest object version-id when versioning is enabled(https://docs.aws.amazon.com/AmazonS3/latest/userguide/AddingObjectstoVersioningEnabledBuckets.html) , and return null or versioning is disabled. 
   So I feel like we can make the " Return latest version of key location for client on createKey/createFile" a common logic, no need to depends on the getLatestVersionLocation. For getLatestVersionLocation is used for key retrieve under versioning case, like the listObject in https://docs.aws.amazon.com/AmazonS3/latest/userguide/manage-objects-versioned-bucket.html.  
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 edited a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 edited a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895931056

> I revisted aws s3 documents, it seems that aws put object API only returns the latest object version-id when versioning is enabled(https://docs.aws.amazon.com/AmazonS3/latest/userguide/AddingObjectstoVersioningEnabledBuckets.html) , and return null when versioning is disabled.

I have used latestVersion boolean in code, and by default it is true, so in that perspective we should be good. And as we have this flag to be consistent in code using this flag should be okay. In this way, we don't remove the old behavior completely.

What returns null? I have not understood that part, care to explain more.

> So I feel like we can make this " Return latest version of key location for client on createKey/createFile" a common logic, no need to depends on the getLatestVersionLocation value. It is more closer to the aws s3 behavior.

We have 2 code paths, in both places when returning from network returning latest version.

I am okay to do change with out using flag, but I think we can remove this every where if it is not required in read path also, as get by default returns latest version. So, this can be addressed in new Jira

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi edited a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi edited a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895764452


   I revisted aws s3 documents, it seems that aws put object API only returns the latest object version-id when versioning is enabled(https://docs.aws.amazon.com/AmazonS3/latest/userguide/AddingObjectstoVersioningEnabledBuckets.html) , and return null when versioning is disabled. 
   So I feel like we can make this " Return latest version of key location for client on createKey/createFile" a common logic, no need to depends on the getLatestVersionLocation value.  It is more closer to the aws s3 behavior. 
   For getLatestVersionLocation is used for key retrieve under versioning case, like the listObject in https://docs.aws.amazon.com/AmazonS3/latest/userguide/manage-objects-versioned-bucket.html.  
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-893228631


   @symious @ChenSammi @kuenishi Now we have HDDS-5472 is in, we can get this in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 edited a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 edited a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895927319


   @ChenSammi I have added the test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi edited a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi edited a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-897299101


   > What returns null? I have not understood that part, care to explain more.
   >
   I means aws s3 put object doesn't return object version if buckt versioning is disabled. 
   
   > I am okay to do change with out using flag, but I think we can remove this every where if it is not required in read path also, as get by default returns latest version. So, this can be addressed in new Jira
   >
   Yes, we can do it in an seperate JIRA.  
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi removed a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi removed a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895764576


   I revisted aws s3 documents, it seems that aws put object API only returns the latest object version-id when versioning is enabled(https://docs.aws.amazon.com/AmazonS3/latest/userguide/AddingObjectstoVersioningEnabledBuckets.html) , and return null or versioning is disabled. 
   So I feel like we can make the " Return latest version of key location for client on createKey/createFile" a common logic, no need to depends on the getLatestVersionLocation. For getLatestVersionLocation is used for key retrieve under versioning case, like the listObject in https://docs.aws.amazon.com/AmazonS3/latest/userguide/manage-objects-versioned-bucket.html.  
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-902597065


   @ChenSammi Added test, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-893228631


   @symious @ChenSammi @kuenishi Now we have HDDS-5472 is in, we can get this in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895931056

What returns null? I have not understood that part, care to explain more.

We have 2 code paths, in both places when returning from network returning latest version.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895934845


   > OmBlockVersioning for this create case?
   
   I have added test in new classes, TestOmBlockVersioning uses old write code path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 edited a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 edited a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895931056

What returns null? I have not understood that part, care to explain more.

We have 2 code paths, in both places when returning from network returning latest version.

**Get behavior on version enabled buckets**

Versioning in Amazon S3 is a way of keeping multiple variants of an object in the same bucket. A simple GET request retrieves the current version of an object. The following figure shows how GET returns the current version of the object, photo.gif.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895764576


   I revisted aws s3 documents, it seems that aws put object API only returns the latest object version-id when versioning is enabled(https://docs.aws.amazon.com/AmazonS3/latest/userguide/AddingObjectstoVersioningEnabledBuckets.html) , and return null or versioning is disabled. 
   So I feel like we can make the " Return latest version of key location for client on createKey/createFile" a common logic, no need to depends on the getLatestVersionLocation. For getLatestVersionLocation is used for key retrieve under versioning case, like the listObject in https://docs.aws.amazon.com/AmazonS3/latest/userguide/manage-objects-versioned-bucket.html.  
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-904361527


   > 
   > 
   > @ChenSammi Added test, PTAL.
   
   The last path LGTM, + 1. 
   
   Thanks @bharatviswa504 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] symious commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

symious commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895680330


   +1 LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] bharatviswa504 edited a comment on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

bharatviswa504 edited a comment on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-895931056

I have used latestVersion boolean in code, and it is by default it is true, so in that perspective we should be good. And as we have this flag to be consistent in code using this flag should be okay. In this way, we don't remove the old behavior completely.

What returns null? I have not understood that part, care to explain more.

We have 2 code paths, in both places when returning from network returning latest version.

**Get behavior on version enabled buckets**

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] symious commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

symious commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-893471259


   Sure, I think we can wait for a green sign?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] ChenSammi commented on pull request #2432: HDDS-5393. Return latest version of key location for client on createKey/createFile

Posted by GitBox <gi...@apache.org>.

ChenSammi commented on pull request #2432:
URL: https://github.com/apache/ozone/pull/2432#issuecomment-897299101


   > What returns null? I have not understood that part, care to explain more.
   I means aws s3 put object doesn't return object version if buckt versioning is disabled. 
   
   > I am okay to do change with out using flag, but I think we can remove this every where if it is not required in read path also, as get by default returns latest version. So, this can be addressed in new Jira
   >
   Yes, we can do it in an seperate JIRA.  
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org