You are viewing a plain text version of this content. The canonical link for it is here.
Posted to surefire-dev@maven.apache.org by "Jesse McConnell (JIRA)" <ji...@codehaus.org> on 2005/11/22 20:08:06 UTC

[jira] Created: (SUREFIRE-19) default excludes prevents inner class test cases

default excludes prevents inner class test cases
------------------------------------------------

         Key: SUREFIRE-19
         URL: http://jira.codehaus.org/browse/SUREFIRE-19
     Project: surefire
        Type: Bug
    Versions: 1.4    
    Reporter: Jesse McConnell
 Assigned to: Jason van Zyl 
     Fix For: 1.5
 Attachments: maven-surefire-plugin.patch, surefire.patch

some people use inner classes for junit tests since they have access to private variables in the unit tests.

for my particular case we have all unit tests called Foo$TEST

in the DirectoryBattery there was a default excludes that was _always_ getting added to exclude inner classes...so the patch attached moves this default exclusion to the listing of default excluders in the maven-surefire-plugin and removed the forced exclusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (SUREFIRE-19) default excludes prevents inner class test cases

Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-19?page=comments#action_51663 ] 

Jesse McConnell commented on SUREFIRE-19:
-----------------------------------------

oh, and I had the assumption that the maven-surefire-plugin is the only thing using surefire....if it isn't I can adjust accordingly

> default excludes prevents inner class test cases
> ------------------------------------------------
>
>          Key: SUREFIRE-19
>          URL: http://jira.codehaus.org/browse/SUREFIRE-19
>      Project: surefire
>         Type: Bug
>     Versions: 1.4
>     Reporter: Jesse McConnell
>     Assignee: Jason van Zyl
>      Fix For: 1.5
>  Attachments: maven-surefire-plugin.patch, surefire.patch
>
>
> some people use inner classes for junit tests since they have access to private variables in the unit tests.
> for my particular case we have all unit tests called Foo$TEST
> in the DirectoryBattery there was a default excludes that was _always_ getting added to exclude inner classes...so the patch attached moves this default exclusion to the listing of default excluders in the maven-surefire-plugin and removed the forced exclusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (SUREFIRE-19) default excludes prevents inner class test cases

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-19?page=all ]
     
Carlos Sanchez closed SUREFIRE-19:
----------------------------------

     Assign To: Carlos Sanchez  (was: Jason van Zyl)
    Resolution: Fixed

> default excludes prevents inner class test cases
> ------------------------------------------------
>
>          Key: SUREFIRE-19
>          URL: http://jira.codehaus.org/browse/SUREFIRE-19
>      Project: surefire
>         Type: Bug

>     Versions: 1.4
>     Reporter: Jesse McConnell
>     Assignee: Carlos Sanchez
>      Fix For: 1.5.2
>  Attachments: maven-surefire-plugin.patch, surefire.patch
>
>
> some people use inner classes for junit tests since they have access to private variables in the unit tests.
> for my particular case we have all unit tests called Foo$TEST
> in the DirectoryBattery there was a default excludes that was _always_ getting added to exclude inner classes...so the patch attached moves this default exclusion to the listing of default excluders in the maven-surefire-plugin and removed the forced exclusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (SUREFIRE-19) default excludes prevents inner class test cases

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-19?page=comments#action_54656 ] 

Carlos Sanchez commented on SUREFIRE-19:
----------------------------------------

I've moved the exclusion from surefire to surefire-plugin, nothing done about the includeProjectClassesBattery option.
Probably is better to close this issue and open another in the surefire plugin about that

> default excludes prevents inner class test cases
> ------------------------------------------------
>
>          Key: SUREFIRE-19
>          URL: http://jira.codehaus.org/browse/SUREFIRE-19
>      Project: surefire
>         Type: Bug

>     Versions: 1.4
>     Reporter: Jesse McConnell
>     Assignee: Jason van Zyl
>      Fix For: 1.5.2
>  Attachments: maven-surefire-plugin.patch, surefire.patch
>
>
> some people use inner classes for junit tests since they have access to private variables in the unit tests.
> for my particular case we have all unit tests called Foo$TEST
> in the DirectoryBattery there was a default excludes that was _always_ getting added to exclude inner classes...so the patch attached moves this default exclusion to the listing of default excluders in the maven-surefire-plugin and removed the forced exclusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (SUREFIRE-19) default excludes prevents inner class test cases

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-19?page=comments#action_52734 ] 

Jason van Zyl commented on SUREFIRE-19:
---------------------------------------

Sorry Jesse, I didn't apply these before I added the forking code. Do you think you could take a peek and see if things still apply and I will push them in asap.

> default excludes prevents inner class test cases
> ------------------------------------------------
>
>          Key: SUREFIRE-19
>          URL: http://jira.codehaus.org/browse/SUREFIRE-19
>      Project: surefire
>         Type: Bug
>     Versions: 1.4
>     Reporter: Jesse McConnell
>     Assignee: Jason van Zyl
>      Fix For: 1.5
>  Attachments: maven-surefire-plugin.patch, surefire.patch
>
>
> some people use inner classes for junit tests since they have access to private variables in the unit tests.
> for my particular case we have all unit tests called Foo$TEST
> in the DirectoryBattery there was a default excludes that was _always_ getting added to exclude inner classes...so the patch attached moves this default exclusion to the listing of default excluders in the maven-surefire-plugin and removed the forced exclusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (SUREFIRE-19) default excludes prevents inner class test cases

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-19?page=all ]

Carlos Sanchez updated SUREFIRE-19:
-----------------------------------

    Fix Version:     (was: 1.5)
                 1.5.2

> default excludes prevents inner class test cases
> ------------------------------------------------
>
>          Key: SUREFIRE-19
>          URL: http://jira.codehaus.org/browse/SUREFIRE-19
>      Project: surefire
>         Type: Bug

>     Versions: 1.4
>     Reporter: Jesse McConnell
>     Assignee: Jason van Zyl
>      Fix For: 1.5.2
>  Attachments: maven-surefire-plugin.patch, surefire.patch
>
>
> some people use inner classes for junit tests since they have access to private variables in the unit tests.
> for my particular case we have all unit tests called Foo$TEST
> in the DirectoryBattery there was a default excludes that was _always_ getting added to exclude inner classes...so the patch attached moves this default exclusion to the listing of default excluders in the maven-surefire-plugin and removed the forced exclusion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira