You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2011/01/25 20:35:45 UTC

[jira] Closed: (LUCENE-1259) Token.clone() copies termBuffer - unneccessary in most cases

     [ https://issues.apache.org/jira/browse/LUCENE-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler closed LUCENE-1259.
---------------------------------

    Resolution: Won't Fix

Token is no longer in use by the TokenStream API and only available to support left over Solr things that still use Token instances instead of AttributeSources..

The new (Char)TermAttribute now only clones the active buffer contents for use cases with cloneAttributes()/copyTo(). But you would not create direct clones anymore.

> Token.clone() copies termBuffer - unneccessary in most cases
> ------------------------------------------------------------
>
>                 Key: LUCENE-1259
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1259
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Thomas Peuss
>            Priority: Minor
>         Attachments: LUCENE-1259.patch
>
>
> The method Token.clone() copies the termBuffer. This is OK for the _clone()_-method (it works according to what we expect from _clone()_). But in most cases the termBuffer is set directly after cloning. This is an unnecessary copy step we can avoid. This patch adds a new method called _cloneWithoutTermBuffer()_.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org