[GitHub] [arrow] kou commented on a change in pull request #9045: Fixup pre-commit-config.yaml so that cmake format runs

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #9045:
URL: https://github.com/apache/arrow/pull/9045#discussion_r550925148



##########
File path: .pre-commit-config.yaml
##########
@@ -40,9 +40,10 @@ repos:
       - id: cmake-format
         name: CMake Format
         language: python
-        entry: bash -c "pip install cmake-format && python run-cmake-format.py --check"
-        entry: echo
-        files: ^(.*/CMakeLists.txt|.*.cmake)$
+        entry: cmake-format --in-place --autosort=false
+        files: CMakeLists\.txt$|^cpp/cmake_modules/
+        additional_dependencies:
+          - cmake_format==0.6.13

Review comment:
       > Anyway, we can't merge this until we fix the following issues:
   > 
   >     * [#9045 (comment)](https://github.com/apache/arrow/pull/9045#issuecomment-752475426)
   > 
   >     * https://github.com/apache/arrow/pull/9045/checks?check_run_id=1629598956
   > 
   > 
   > Could you fix them?
   
   Thanks for fixing the latter.
   Could you also fix the former?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org