You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/01/21 12:16:26 UTC
[GitHub] [camel-k] jamesnetherton opened a new pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton opened a new pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931
<!-- Description -->
Depends on an as-yet uncommitted change to camel-k-runtime (hence draft PR), but this PR provides the means to support the Quarkus fast-jar format.
At the moment fast-jar expects a specific directory structure, so I've had to replicate that in the container under `/deployment/dependencies` .
Also I assumed it's safe to not use the `generate-dependency-list` mojo since the `quarkus-maven-plugin` already does its own dependency resolution and downloading of artifacts.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764737470
So I think that today we have the same issue with the jar containing the quarkus-generated main function. If I understand this correctly this will now apply to the rest of the dependencies too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764723809
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788792687
Conflicts resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764743929
Here's some example output from `kamel inspect examples/Sample.java --all-dependencies`.
```
/tmp/maven-485089909/target/quarkus-app/app/camel-k-integration-1.4.0-SNAPSHOT.jar
/tmp/maven-485089909/target/quarkus-app/lib/boot/io.quarkus.quarkus-bootstrap-runner-1.11.0.Final.jar
/tmp/maven-485089909/target/quarkus-app/lib/boot/io.quarkus.quarkus-development-mode-spi-1.11.0.Final.jar
/tmp/maven-485089909/target/quarkus-app/lib/boot/io.smallrye.common.smallrye-common-io-1.5.0.jar
/tmp/maven-485089909/target/quarkus-app/lib/boot/org.jboss.logging.jboss-logging-3.4.1.Final.jar
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788858497
@astefanutti are we good to merge this one? The usual flaky tests failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764729074
If that's the case then we now have even more need of a means of saving the dependencies after the command is completed and the temporary folder is removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788940344
> Added the additional config to the `ServiceMonitor` (hopefully correctly).
Perfect, LGTM 👍🏼.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788926429
@jamesnetherton one last point, as the metrics endpoint exposed by Quarkus has its path changed, I think the `ServiceMonitor` resource created by the prometheus trait must have the path explicitly specified. The e2e monitoring tests only run on OCP 4 downstream, which explain why CI didn't surface the problem. I'm fine handling it if you prefer right after it's merged. Let me know.
/cc @llowinge who wrote the monitoring e2e tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764766938
> Does the image run successfully?
Yes, that part works. The integration tests verify that and I did some of my own testing on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton merged pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764762022
I see, I mean that would be ok for the narrow purposes of the inspect command but unless they can be saved in another folder then those dependencies will not be there after the command completes.
The question is, when trying to containerize the application. If you run:
```
kamel local create --image <name> examples/Sample.java
kamel local run --image <name>
```
Does the image run successfully?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-787786140
I don't understand why there are random failures in the YAKS knative tests. They don't occur for me locally.
I've put this PR back into review and it's good to merge IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-789031361
I'll merge as I'd like to not have to rebase this one again...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788785164
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-787788529
Thanks for the update. Yes, there are some flaky YAKS tests, that are not caused by your changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788935971
Added the additional config to the `ServiceMonitor` (hopefully correctly).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764720554
Will this work with local dependency resolution? It would be good to at least try it out with the set of local commands which use the current way of resolving dependencies. For example running `kamel inspect` and `kamel inspect --all-dependencies`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-789024955
Woah! A successful build :sweat_smile:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764637620
Very nice! It may impact #1816.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764723809
> Will this work with local dependency resolution? It would be good to at least try it out with the set of local commands which use the current way of resolving dependencies. For example running `kamel inspect` and `kamel inspect --all-dependencies`.
I did test that and it looked to be working ok. Also ran the 'local' integration test suite and it passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-765457997
Seems a Spectrum tweak is also required, so opened https://github.com/container-tools/spectrum/pull/4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 edited a comment on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
doru1004 edited a comment on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764737470
So I think that today we have the same issue with the jar containing the quarkus-generated main function. If I understand correctly this will now apply to the rest of the dependencies too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764637620
Very nice! It may impact #1816.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 edited a comment on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
doru1004 edited a comment on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764737470
So I think that today we have the same issue with the jar containing the quarkus-generated main function. If I understand correctly this will now apply to the rest of the dependencies too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764720554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] doru1004 commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
doru1004 commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764775962
Awesome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1931:
URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764726552
> I did test that and it looked to be working ok
Actually now I think about it a bit more, maybe it isn't....
The paths listed are to the temp maven build directory, which I guess is not correct (since it is 'temporary')? I suppose the paths are meant to resolve to the artifacts in the local m2 repository?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org