[jira] [Comment Edited] (MADLIB-1172) Logistic regression produces empty output table but no error message on Greenplum

["Frank McQuillan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MADLIB-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498722#comment-16498722 ] 

Frank McQuillan edited comment on MADLIB-1172 at 6/1/18 11:50 PM:
------------------------------------------------------------------

LGTM

{code}
DROP TABLE IF EXISTS dummy_logit_gp, dummy_logit_gp_summary;
SELECT madlib.logregr_train('dummy_data_gp'
                      , 'dummy_logit_gp'
                      , 'y'
                      , 'ARRAY[1,x1,x2,x3,x4,x5]'
                      , NULL
                      , 20
                      , 'irls'
                      );
{code}
produces a proper warning message now
{code}
ERROR:  plpy.Error: Logregr error: No model created possibly due to ill-conditioned data. (plpython.c:4960)
CONTEXT:  Traceback (most recent call last):
  PL/Python function "logregr_train", line 23, in <module>
    return logistic.logregr_train(**globals())
  PL/Python function "logregr_train", line 133, in logregr_train
  PL/Python function "logregr_train", line 349, in __logregr_train_compute
PL/Python function "logregr_train"
{code}

{code}
SELECT * FROM dummy_logit_gp;
{code}
correctly produces no model table
{code}
ERROR:  relation "dummy_logit_gp" does not exist
LINE 1: SELECT * FROM dummy_logit_gp;
{code}



was (Author: fmcquillan):

{code}
DROP TABLE IF EXISTS dummy_logit_gp, dummy_logit_gp_summary;
SELECT madlib.logregr_train('dummy_data_gp'
                      , 'dummy_logit_gp'
                      , 'y'
                      , 'ARRAY[1,x1,x2,x3,x4,x5]'
                      , NULL
                      , 20
                      , 'irls'
                      );
{code}
produces a proper warning message now
{code}
ERROR:  plpy.Error: Logregr error: No model created possibly due to ill-conditioned data. (plpython.c:4960)
CONTEXT:  Traceback (most recent call last):
  PL/Python function "logregr_train", line 23, in <module>
    return logistic.logregr_train(**globals())
  PL/Python function "logregr_train", line 133, in logregr_train
  PL/Python function "logregr_train", line 349, in __logregr_train_compute
PL/Python function "logregr_train"
{code}

LGTM

> Logistic regression produces empty output table but no error message on Greenplum
> ---------------------------------------------------------------------------------
>
>                 Key: MADLIB-1172
>                 URL: https://issues.apache.org/jira/browse/MADLIB-1172
>             Project: Apache MADlib
>          Issue Type: Bug
>          Components: Module: Logistic Regression
>            Reporter: Frank McQuillan
>            Assignee: Himanshu Pandey
>            Priority: Minor
>             Fix For: v1.15
>
>         Attachments: Logistic-regression-empty-output.ipynb, load-data-sep.sql, load-data-singular.sql, load-data.sql
>
>
> Separated and singular data sets may produce and empty model table on Greenplum 4.3.x.  On Postgres 9.6 the same example works OK. 
> See the attache jupyter notebook and data sets for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)