You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by vi...@apache.org on 2016/06/14 10:30:26 UTC

[1/2] hadoop git commit: HADOOP-13179. GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe. (Contributed by hongbin ma)

Repository: hadoop
Updated Branches:
  refs/heads/branch-2 cd3bdbc70 -> 06b76f158
  refs/heads/branch-2.8 8295351e5 -> 3bf5379ad


HADOOP-13179. GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe. (Contributed by hongbin ma)

(cherry picked from commit 5cd19e429e7aef8751599dc5f54ffe29a9dc3ea9)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/06b76f15
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/06b76f15
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/06b76f15

Branch: refs/heads/branch-2
Commit: 06b76f15869e072261ba10b3e9059bbafae8c7f8
Parents: cd3bdbc
Author: Vinayakumar B <vi...@apache.org>
Authored: Tue Jun 14 15:58:04 2016 +0530
Committer: Vinayakumar B <vi...@apache.org>
Committed: Tue Jun 14 15:59:07 2016 +0530

----------------------------------------------------------------------
 .../src/main/java/org/apache/hadoop/util/GenericOptionsParser.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/06b76f15/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
index 925aad6..cdc7b59 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
@@ -208,7 +208,7 @@ public class GenericOptionsParser {
    * Specify properties of each generic option
    */
   @SuppressWarnings("static-access")
-  private static Options buildGeneralOptions(Options opts) {
+  private static synchronized Options buildGeneralOptions(Options opts) {
     Option fs = OptionBuilder.withArgName("local|namenode:port")
     .hasArg()
     .withDescription("specify a namenode")


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org

[2/2] hadoop git commit: HADOOP-13179. GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe. (Contributed by hongbin ma)

Posted by vi...@apache.org.
HADOOP-13179. GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe. (Contributed by hongbin ma)

(cherry picked from commit 5cd19e429e7aef8751599dc5f54ffe29a9dc3ea9)
(cherry picked from commit 06b76f15869e072261ba10b3e9059bbafae8c7f8)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/3bf5379a
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/3bf5379a
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/3bf5379a

Branch: refs/heads/branch-2.8
Commit: 3bf5379adb3585ed0203ae1d90e1c3b5d34cc272
Parents: 8295351
Author: Vinayakumar B <vi...@apache.org>
Authored: Tue Jun 14 15:58:04 2016 +0530
Committer: Vinayakumar B <vi...@apache.org>
Committed: Tue Jun 14 15:59:36 2016 +0530

----------------------------------------------------------------------
 .../src/main/java/org/apache/hadoop/util/GenericOptionsParser.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/3bf5379a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
index 925aad6..cdc7b59 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
@@ -208,7 +208,7 @@ public class GenericOptionsParser {
    * Specify properties of each generic option
    */
   @SuppressWarnings("static-access")
-  private static Options buildGeneralOptions(Options opts) {
+  private static synchronized Options buildGeneralOptions(Options opts) {
     Option fs = OptionBuilder.withArgName("local|namenode:port")
     .hasArg()
     .withDescription("specify a namenode")


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org