You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/09 23:52:25 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10823: fix: Making the database/cluster read-only
codecov-commenter commented on pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823#issuecomment-689884277
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=h1) Report
> Merging [#10823](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c2216e029d09938cf1ecef82e1cf7e435908dbe3?el=desc) will **decrease** coverage by `4.97%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10823 +/- ##
==========================================
- Coverage 65.43% 60.46% -4.98%
==========================================
Files 803 374 -429
Lines 37930 23966 -13964
Branches 3561 0 -3561
==========================================
- Hits 24818 14490 -10328
+ Misses 13008 9476 -3532
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.46% <77.77%> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.28% <ø> (ø)` | |
| [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `71.42% <66.66%> (-3.58%)` | :arrow_down: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.79% <100.00%> (+0.41%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-2.70%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.66% <0.00%> (-1.39%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.22% <0.00%> (-0.25%)` | :arrow_down: |
| ... and [428 more](https://codecov.io/gh/apache/incubator-superset/pull/10823/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=footer). Last update [c2216e0...368babf](https://codecov.io/gh/apache/incubator-superset/pull/10823?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org