You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/27 16:28:19 UTC

Review Request 27228: User may skip steps on Slider Wizard

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27228/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk and Andrii Tkach.


Bugs: Ambari-7987
    https://issues.apache.org/jira/browse/Ambari-7987


Repository: ambari


Description
-------

Open Wizard.
Input App name.
Click Next several times. 
Next steps may be skipped.


Diffs
-----

  contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step1_controller.js 0a59916 
  contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js fcf32c5 
  contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step1_controller_test.js aea7585 

Diff: https://reviews.apache.org/r/27228/diff/


Testing
-------

Tests completed in 10487 milliseconds.
151 assertions of 151 passed, 0 failed.


Thanks,

Oleg Nechiporenko


Re: Review Request 27228: User may skip steps on Slider Wizard

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27228/#review58611
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Окт. 27, 2014, 3:28 п.п., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27228/
> -----------------------------------------------------------
> 
> (Updated Окт. 27, 2014, 3:28 п.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Andrii Tkach.
> 
> 
> Bugs: Ambari-7987
>     https://issues.apache.org/jira/browse/Ambari-7987
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Open Wizard.
> Input App name.
> Click Next several times. 
> Next steps may be skipped.
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step1_controller.js 0a59916 
>   contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js fcf32c5 
>   contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step1_controller_test.js aea7585 
> 
> Diff: https://reviews.apache.org/r/27228/diff/
> 
> 
> Testing
> -------
> 
> Tests completed in 10487 milliseconds.
> 151 assertions of 151 passed, 0 failed.
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>


Re: Review Request 27228: User may skip steps on Slider Wizard

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27228/#review58612
-----------------------------------------------------------

Ship it!


Ship It!

- Andrii Tkach


On Окт. 27, 2014, 3:28 п.п., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27228/
> -----------------------------------------------------------
> 
> (Updated Окт. 27, 2014, 3:28 п.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Andrii Tkach.
> 
> 
> Bugs: Ambari-7987
>     https://issues.apache.org/jira/browse/Ambari-7987
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Open Wizard.
> Input App name.
> Click Next several times. 
> Next steps may be skipped.
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step1_controller.js 0a59916 
>   contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js fcf32c5 
>   contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step1_controller_test.js aea7585 
> 
> Diff: https://reviews.apache.org/r/27228/diff/
> 
> 
> Testing
> -------
> 
> Tests completed in 10487 milliseconds.
> 151 assertions of 151 passed, 0 failed.
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>