[jira] [Resolved] (KAFKA-1302) cleanup logging in new producer

["Jun Rao (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jun Rao resolved KAFKA-1302.
----------------------------

       Resolution: Fixed
    Fix Version/s: 0.8.2

Thanks for the reviews. Committed to trunk.

> cleanup logging in new producer
> -------------------------------
>
>                 Key: KAFKA-1302
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1302
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.2
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.8.2
>
>         Attachments: KAFKA-1302.patch, KAFKA-1302_2014-03-13_11:00:33.patch
>
>
> 1. When we hit an error in producer, we call the callback with a null RecordMetadata. If the callback tries to get the topic/partition, it will hit a NullPointerException. It's probably better to create a RecordMetadata with -1 as the offset.
> 2. When printing out a Struct, we don't print out the content wrapped in an array properly. So, we will see sth like the following.
> [2014-03-09 11:56:24,364] INFO Created 1 requests: [InFlightRequest(expectResponse=true, batches={test-0=RecordBatch(topicPartition=test-0, recordCount=1)}, request=RequestSend(header={api_key=0,api_version=0,correlation_id=1,client_id=perf-test}, body={acks=-1,timeout=3000,topic_data=[Ljava.lang.Object;@700a4488}))] (org.apache.kafka.clients.producer.internals.Sender)
> 3. Need to override the toString() in ProduceResponse.
> 4. Sender.run(now): It would be good to log metadata request too.
> 5. Sender.handleDisconnects(): It would be useful to log the correlation id of cancelled inflight requests



--
This message was sent by Atlassian JIRA
(v6.2#6252)