[GitHub] rhtyd closed pull request #2907: client: mgmt server listen default to 0.0.0.0

[GitBox <gi...@apache.org>]

rhtyd closed pull request #2907: client: mgmt server listen default to 0.0.0.0
URL: https://github.com/apache/cloudstack/pull/2907
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/client/conf/server.properties.in b/client/conf/server.properties.in
index f255128555c..6cb56922b48 100644
--- a/client/conf/server.properties.in
+++ b/client/conf/server.properties.in
@@ -16,7 +16,8 @@
 # under the License.
 
 # The binding interface for the management server
-bind.interface=::
+# The management server will listen on all interfaces by default
+# bind.interface=::
 
 # The service context path where URL requests should be served
 context.path=/client
diff --git a/client/src/org/apache/cloudstack/ServerDaemon.java b/client/src/org/apache/cloudstack/ServerDaemon.java
index 985b67b755a..6d273834e4b 100644
--- a/client/src/org/apache/cloudstack/ServerDaemon.java
+++ b/client/src/org/apache/cloudstack/ServerDaemon.java
@@ -85,7 +85,7 @@
     private int sessionTimeout = 30;
     private boolean httpsEnable = false;
     private String accessLogFile = "access.log";
-    private String bindInterface = "";
+    private String bindInterface = null;
     private String contextPath = "/client";
     private String keystoreFile;
     private String keystorePassword;
@@ -117,7 +117,7 @@ public void init(final DaemonContext context) {
             if (properties == null) {
                 return;
             }
-            setBindInterface(properties.getProperty(BIND_INTERFACE, ""));
+            setBindInterface(properties.getProperty(BIND_INTERFACE, null));
             setContextPath(properties.getProperty(CONTEXT_PATH, "/client"));
             setHttpPort(Integer.valueOf(properties.getProperty(HTTP_PORT, "8080")));
             setHttpsEnable(Boolean.valueOf(properties.getProperty(HTTPS_ENABLE, "false")));


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services