You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/26 21:49:47 UTC

[GitHub] GabeLoins opened a new pull request #4486: Gabe applying refresh chart overlay when chart is stale

GabeLoins opened a new pull request #4486: Gabe applying refresh chart overlay when chart is stale
URL: https://github.com/apache/incubator-superset/pull/4486
 
 
   This is a follow up to apache#4459 to make it more obvious when the chart should be refreshed.
   
   after making a change affecting the query:
   ![image](https://user-images.githubusercontent.com/2455694/36697122-fb26bb96-1afa-11e8-904d-ac33ee7fdab8.png)
   
   but if you make a change causing errors:
   ![image](https://user-images.githubusercontent.com/2455694/36697130-013c69fe-1afb-11e8-9db1-08c2163aa3a5.png)
   
   test plan:
   - make a change to the query params
   - verify the overlay appears
   - verify run query works
   - verify the overlay can be dismissed
   
   reviewers:
   @graceguo-supercat @michellethomas @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services