You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2024/07/18 20:06:19 UTC
[I] The `TS_HAS_TLS_EARLY_DATA` define can never evaluate as false [trafficserver]
JosiahWI opened a new issue, #11575:
URL: https://github.com/apache/trafficserver/issues/11575
```cmake
+set(TS_HAS_TLS_EARLY_DATA
+ ${HAVE_SSL_SET_MAX_EARLY_DATA}
+ |
+ ${HAVE_SSL_READ_EARLY_DATA}
+ |
+ ${HAVE_SSL_WRITE_EARLY_DATA}
+ |
+ ${HAVE_SSL_IN_EARLY_DATA}
+)
# I added this debug message locally to demonstrate the problem.
message(STATUS "The TS_HAS_TLS_EARLY_DATA variable has the value \"${TS_HAS_TLS_EARLY_DATA}\".")
```
-- The TS_HAS_TLS_EARLY_DATA variable has the value "1;|;1;|;1;|".
```
This was added in #11215 and this incorrect logic is now being copied to other places (#11564). I have tested the impact of this incorrect value by simulating the absence of any TLS early data support, and checking the value of the define in a source file.
```cmake
set(TS_HAS_TLS_EARLY_DATA "0" | "0" | "0" | "0")
```
```cpp
// in CacheWrite.cc
#if TS_HAS_TLS_EARLY_DATA
#error "not good"
#endif
```
Output from GCC:
```
/trafficserver/src/iocore/cache/CacheWrite.cc:30:2: error: #error "not good"
30 | #error "not good"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] The `TS_HAS_TLS_EARLY_DATA` define can never evaluate as false [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI closed issue #11575: The `TS_HAS_TLS_EARLY_DATA` define can never evaluate as false
URL: https://github.com/apache/trafficserver/issues/11575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] The `TS_HAS_TLS_EARLY_DATA` define can never evaluate as false [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI closed issue #11575: The `TS_HAS_TLS_EARLY_DATA` define can never evaluate as false
URL: https://github.com/apache/trafficserver/issues/11575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org