You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dstandish (via GitHub)" <gi...@apache.org> on 2024/12/06 19:37:07 UTC
[PR] Add constant for airflow base version [airflow]
dstandish opened a new pull request, #44743:
URL: https://github.com/apache/airflow/pull/44743
This is meant to be used in providers. E.g.
```
if AIRFLOW_BASE_VERSION >= "2.10.0":
do_something()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add constant for airflow base version [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #44743: Add constant for airflow base version
URL: https://github.com/apache/airflow/pull/44743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add constant for airflow base version [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44743:
URL: https://github.com/apache/airflow/pull/44743#issuecomment-2614630466
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add constant for airflow base version [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #44743:
URL: https://github.com/apache/airflow/pull/44743#discussion_r1873984144
##########
providers/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -265,6 +261,6 @@ def get_openlineage_database_dialect(self, connection: Connection) -> str:
def get_openlineage_default_schema(self) -> str | None:
"""Return current schema. This is usually changed with ``SEARCH_PATH`` parameter."""
- if _IS_AIRFLOW_2_10_OR_HIGHER:
+ if AIRFLOW_BASE_VERSION >= "2.10.0":
return self.get_first("SELECT CURRENT_SCHEMA();")[0]
Review Comment:
just did this one as an example; it cannot be used until min airlfow version is ... whenever this constant is introduced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add constant for airflow base version [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #44743:
URL: https://github.com/apache/airflow/pull/44743#issuecomment-2575546944
I think we no longer need this PR? cc @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org