[GitHub] [incubator-daffodil] mbeckerle commented on pull request #482: Update debugger support of found delimiters/fields/diffs

[GitBox <gi...@apache.org>]

mbeckerle commented on pull request #482:
URL: https://github.com/apache/incubator-daffodil/pull/482#issuecomment-769378744


   I like the concept of eliminating the before-capture, and using the prior after-state as the incoming before state. Code does look cleaned up a bit. 
   
   I think it will be nearly equivalent when used. Instead of showing diffs for only one element you'd have to stop before that element, then single step then info diff to see only the deltas for that one step. Seems fine. 
   
   I think the real proof of this will be how well it works out for unparsing. 
   
   btw I think when debugging, it's highly likely we want to retry all suspensions at each stop (repeating until no more of them successfully evaluate).  At least that should be one mode which is to evaluate suspensions as soon as possible. Perhaps another mode would evaluate them "normally", but I fear this will just be viewed as non-deterministic by users. They won't have any idea why things are being evaluated at various points. 
   
   I'm just waiting for some tests to one-plus this. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org