You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "minhyeok kweun (JIRA)" <ji...@apache.org> on 2016/08/08 08:30:20 UTC

[jira] [Commented] (REEF-968) Handle RequiredParameter set to null

    [ https://issues.apache.org/jira/browse/REEF-968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411483#comment-15411483 ] 

minhyeok kweun commented on REEF-968:
-------------------------------------

[~dss-2009@yandex.ru], I'm afriad but I haven't made any progress since I didn't receive any comment on my question at all until now. I'm going to drop this issue and it may be dealt by someone else..

> Handle RequiredParameter set to null
> ------------------------------------
>
>                 Key: REEF-968
>                 URL: https://issues.apache.org/jira/browse/REEF-968
>             Project: REEF
>          Issue Type: Sub-task
>          Components: Tang
>            Reporter: Sergey Dudoladov
>            Assignee: minhyeok kweun
>
> Attempt to set a {{RequiredParameter}}  to null should probably use a default value if available or throw a meaningful exception.
> To reproduce, see [the comment to REEF-932 | https://issues.apache.org/jira/browse/REEF-932?focusedCommentId=15009618&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15009618]
> I modified that patch to include the default value for 
> {code}
> @NamedParameter(default_value = "abc")
>   class FooStringness implements Name<String> {
>   }
> {code}
>  but that code also throws {{IllegalStateException}}. 
> We probably should use the default value instead and log (a) the warning that the {{RequiredParameter}} is set to null (b) the default we use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)