[GitHub] [druid] gianm commented on a diff in pull request #12099: Task queue unblock

[GitBox <gi...@apache.org>]

gianm commented on code in PR #12099:
URL: https://github.com/apache/druid/pull/12099#discussion_r855684180


##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -93,7 +100,8 @@
   private final ServiceEmitter emitter;
 
   private final ReentrantLock giant = new ReentrantLock(true);
-  private final Condition managementMayBeNecessary = giant.newCondition();
+  @SuppressWarnings("MismatchedQueryAndUpdateOfCollection")
+  private final BlockingQueue<Object> managementMayBeNecessary = new ArrayBlockingQueue<>(8);

Review Comment:
   Any reason why this is 8 instead of 1? I suppose it doesn't matter what the size is, since the queue is cleared in awaitManagementNanos. I'm just wondering if there's a reason I'm missing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org