You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/29 09:18:18 UTC

[GitHub] [flink] dawidwys commented on pull request #12379: [FLINK-18001][table-planner] Add a new test base for evaluating functions

dawidwys commented on pull request #12379:
URL: https://github.com/apache/flink/pull/12379#issuecomment-635868816


   I like moving the matcher much more than adding the dependency! Generally code changes look good to me.
   
   One thing, that as we moved the matcher we can probably remove test dependencies on flink-core test-jar in couple of modules, e.g. `flink-connector-hbase_2.11` (I have not checked it, but I am pretty sure we can in some of the modules as this dependency was added recently for table tests).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org