You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/05 09:07:04 UTC
[GitHub] [apisix-docker] sober-wang opened a new pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
sober-wang opened a new pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128
we can use `kubectl logs` and `docker logs` review apisix container's logs
```shell
kubectl -n <YOUR_NAMEPSACES> logs <APISIX_POD>
docker logs <APISIX_CONTAINERS>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] imjoey commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-778570429
Hi @sober-wang , thank you. Could you please add relevant test cases in CI to check the logs output? That would make the PR much reliable. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-781870162
I added a CI in #133 , we can merge this PR after #133 merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] imjoey commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-781031887
> I know your mean's. But can you help me ,how to create a test cases in CI.
Hi @sober-wang , you could try login via curl and then see if `docker logs` contains relevant logs, please refer to https://github.com/apache/apisix-dashboard/blob/8e1854704d5545f7574fb69fe2710f19871279fd/.github/workflows/backend-unit-test.yml#L55-L61 for example.
BTW: I checked out your code in my local MacOS, but unfortunately I was not able to see continuous logs output via `docker logs`. Of course, perhaps there's something wrong with my environment. 😄 So additional checks in CI would be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-785606901
We can continue to review this pr, @sober-wang Need to modify the document format as @imjoey suggest.
As #133 has been merged, we need to rebase master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] spacewander closed pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] sober-wang commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
sober-wang commented on pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-781284917
> > I know your mean's. But can you help me ,how to create a test cases in CI.
>
> Hi @sober-wang , you could try login via curl and then see if `docker logs` contains relevant logs, please refer to https://github.com/apache/apisix-dashboard/blob/8e1854704d5545f7574fb69fe2710f19871279fd/.github/workflows/backend-unit-test.yml#L55-L61 for example.
>
> BTW: I checked out your code in my local MacOS, but unfortunately I was not able to see continuous logs output via `docker logs`. Of course, perhaps there's something wrong with my environment. 😄 So additional checks in CI would be better.
maybe , you should do something look like this
```shell
cd apisix-docker/centos
docker build -t newapisix-image:20210218
docker run -d -p 9080:9080 --name=newapisix newapisix-image:20210218
# next used
docker logs newapisix
# you'll see the apisix logs in stdout
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] imjoey commented on a change in pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128#discussion_r575627698
##########
File path: alpine/Dockerfile
##########
@@ -40,6 +40,10 @@ COPY --from=production-stage /usr/bin/apisix /usr/bin/apisix
ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/usr/local/openresty/bin
+# apisix's logs will output the stdout and stderr. we can use commend `kubectl logs` and `docker logs` review apisix's logs
Review comment:
```suggestion
# APISIX's logs will output the stdout and stderr. We can use command `kubectl logs` and `docker logs` to review APISIX's logs
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] sober-wang commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
sober-wang commented on pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-778589910
I know your mean's. But can you help me ,how to create a test cases in CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] spacewander commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #128:
URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-811567765
Solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org