You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by scwf <gi...@git.apache.org> on 2014/03/21 04:24:01 UTC
[GitHub] spark pull request: Update StageTable.scala
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/192
Update StageTable.scala
fix the problem that the numbers on progress bar move along with task progress until invisible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scwf/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #192
----
commit 1c6d332327de03a631918860d200fc69e056dfa8
Author: scwf <wa...@huawei.com>
Date: 2014-03-21T03:23:42Z
Update StageTable.scala
fix the problem that the numbers on progress bar move along with task progress until invisible
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/192#discussion_r10827385
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -60,11 +60,13 @@ private[ui] class StageTable(stages: Seq[StageInfo], parent: JobProgressUI) {
private def makeProgressBar(started: Int, completed: Int, failed: String, total: Int): Seq[Node] =
{
- val completeWidth = "width: %s%%".format((completed.toDouble/total)*100)
- val startWidth = "width: %s%%".format((started.toDouble/total)*100)
+ val startPct = (started.toDouble/total)*100
+ val completePct = (completed.toDouble/total)*100
+ val completeWidth = "width: %s%%; position: absolute;".format(completePct)
+ val startWidth = "width: %s%%; left: %s%%; position: absolute;".format(startPct,completePct)
--- End diff --
(started.toDouble/total)*100 --> started.toDouble/total*100 . this error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38247635
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/192#discussion_r10826804
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -60,11 +60,11 @@ private[ui] class StageTable(stages: Seq[StageInfo], parent: JobProgressUI) {
private def makeProgressBar(started: Int, completed: Int, failed: String, total: Int): Seq[Node] =
{
- val completeWidth = "width: %s%%".format((completed.toDouble/total)*100)
- val startWidth = "width: %s%%".format((started.toDouble/total)*100)
+ val completeWidth = "width: %s%%; position: absolute;".format((completed.toDouble/total)*100)
+ val startWidth = "width: %s%%; left: %s%%; position: absolute;".format((started.toDouble/total)*100)
--- End diff --
This line is too long for the style guide. Also - will this throw a string format exception? (there are two cases of %s but only one argument passed to `format`.
```
val startPct = (started.toDouble/total)*100
val startWidth = "width: %s%%; left: %s%%; position: absolute;".format(startPct, startPct)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38247763
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/192#discussion_r10827324
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -60,11 +60,13 @@ private[ui] class StageTable(stages: Seq[StageInfo], parent: JobProgressUI) {
private def makeProgressBar(started: Int, completed: Int, failed: String, total: Int): Seq[Node] =
{
- val completeWidth = "width: %s%%".format((completed.toDouble/total)*100)
- val startWidth = "width: %s%%".format((started.toDouble/total)*100)
+ val startPct = (started.toDouble/total)*100
+ val completePct = (completed.toDouble/total)*100
+ val completeWidth = "width: %s%%; position: absolute;".format(completePct)
+ val startWidth = "width: %s%%; left: %s%%; position: absolute;".format(startPct,completePct)
--- End diff --
`startPct, completePct` (small style thing)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by scwf <gi...@git.apache.org>.
Github user scwf closed the pull request at:
https://github.com/apache/spark/pull/192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38247764
One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13311/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38247712
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/192#discussion_r10827401
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -60,11 +60,13 @@ private[ui] class StageTable(stages: Seq[StageInfo], parent: JobProgressUI) {
private def makeProgressBar(started: Int, completed: Int, failed: String, total: Int): Seq[Node] =
{
- val completeWidth = "width: %s%%".format((completed.toDouble/total)*100)
- val startWidth = "width: %s%%".format((started.toDouble/total)*100)
+ val startPct = (started.toDouble/total)*100
+ val completePct = (completed.toDouble/total)*100
+ val completeWidth = "width: %s%%; position: absolute;".format(completePct)
+ val startWidth = "width: %s%%; left: %s%%; position: absolute;".format(startPct,completePct)
--- End diff --
No it's just, put a space between these:
```
val startWidth = "width: %s%%; left: %s%%; position: absolute;".format(startPct, completePct)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/192#discussion_r10827186
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -60,11 +60,11 @@ private[ui] class StageTable(stages: Seq[StageInfo], parent: JobProgressUI) {
private def makeProgressBar(started: Int, completed: Int, failed: String, total: Int): Seq[Node] =
{
- val completeWidth = "width: %s%%".format((completed.toDouble/total)*100)
- val startWidth = "width: %s%%".format((started.toDouble/total)*100)
+ val completeWidth = "width: %s%%; position: absolute;".format((completed.toDouble/total)*100)
+ val startWidth = "width: %s%%; left: %s%%; position: absolute;".format((started.toDouble/total)*100)
--- End diff --
that is right, i made a mistake and i will update this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38249967
Thanks a lot for looking into this. Just a small style error - mind fixing it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/192#discussion_r10827485
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -60,11 +60,13 @@ private[ui] class StageTable(stages: Seq[StageInfo], parent: JobProgressUI) {
private def makeProgressBar(started: Int, completed: Int, failed: String, total: Int): Seq[Node] =
{
- val completeWidth = "width: %s%%".format((completed.toDouble/total)*100)
- val startWidth = "width: %s%%".format((started.toDouble/total)*100)
+ val startPct = (started.toDouble/total)*100
+ val completePct = (completed.toDouble/total)*100
+ val completeWidth = "width: %s%%; position: absolute;".format(completePct)
+ val startWidth = "width: %s%%; left: %s%%; position: absolute;".format(startPct,completePct)
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38247711
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38759931
I can't close it. You need to close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38713226
Hey @scwf I didn't realize - but this was fixed already in parallel by #201 (merged by @aarondav). Mind closing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/192#discussion_r10827457
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -60,11 +60,13 @@ private[ui] class StageTable(stages: Seq[StageInfo], parent: JobProgressUI) {
private def makeProgressBar(started: Int, completed: Int, failed: String, total: Int): Seq[Node] =
{
- val completeWidth = "width: %s%%".format((completed.toDouble/total)*100)
- val startWidth = "width: %s%%".format((started.toDouble/total)*100)
+ val startPct = (started.toDouble/total)*100
+ val completePct = (completed.toDouble/total)*100
+ val completeWidth = "width: %s%%; position: absolute;".format(completePct)
+ val startWidth = "width: %s%%; left: %s%%; position: absolute;".format(startPct,completePct)
--- End diff --
ok, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38247699
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38758053
On 2014/3/27 1:25, Patrick Wendell wrote:
> Hey @scwf <https://github.com/scwf> I didn't realize - but this was
> fixed already in parallel by #201
> <https://github.com/apache/spark/pull/201> (merged by @aarondav
> <https://github.com/aarondav>). Mind closing this?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/192#issuecomment-38713226>.
>
ok, close it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update StageTable.scala
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/192#issuecomment-38250081
sorry,i am new. style error? the name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---