You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Meng Zhu (JIRA)" <ji...@apache.org> on 2019/04/25 21:50:00 UTC
[jira] [Commented] (MESOS-9724) Flatten the weighted shuffling in
the random sorter.
[ https://issues.apache.org/jira/browse/MESOS-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826492#comment-16826492 ]
Meng Zhu commented on MESOS-9724:
---------------------------------
{noformat}
commit 5108f076e6a5c275cae6b124bbcb110bc6785f94
Author: Meng Zhu <mz...@mesosphere.io>
Date: Wed Apr 24 11:32:38 2019 -0700
Avoided some recalculation in the random sorter.
This patch keeps the sorting related information in the memory
and accompanies a dirty bit with it. This helps to avoid
unnecessary recalculation of this info in `sort()`.
Review: https://reviews.apache.org/r/70430
commit 5a756402ad15cedbc6ccb8fa5de096745967f36f
Author: Meng Zhu <mz...@mesosphere.io>
Date: Wed Apr 24 10:51:06 2019 -0700
Fixed a bug in the random sorter.
Currently, in the presence of hierarchical roles, the
random sorter shuffles roles level by level and then pick
the active leave nodes using DFS. This could generate
non-uniform random result since active leaves in a subtree
are always picked together.
This patch fixes the issue by first calculating the relative
weights of each active leaf node and shuffle all of them
only once.
Review: https://reviews.apache.org/r/70429
commit 5e52c686c29819113f42c6bde7d90324673b42dc
Author: Meng Zhu <mz...@mesosphere.io>
Date: Tue Apr 23 18:44:33 2019 -0700
Added a random sorter helper to find active internal nodes.
Active internal nodes are defined as internal nodes that have
at least one active leaf node.
Review: https://reviews.apache.org/r/70542
{noformat}
> Flatten the weighted shuffling in the random sorter.
> ----------------------------------------------------
>
> Key: MESOS-9724
> URL: https://issues.apache.org/jira/browse/MESOS-9724
> Project: Mesos
> Issue Type: Improvement
> Reporter: Meng Zhu
> Assignee: Meng Zhu
> Priority: Major
> Labels: performance, resource-management
>
> Due to the presence of hierarchical weights, the random sorter currently shuffles level-by-level. We should be able to shuffle all the active leaves only once by calculating (and caching) active leaves' relative weights. This should improve the performance in the presence of hierarchical roles.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)