You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Sean Sullivan <se...@seansullivan.com> on 2007/06/19 01:39:56 UTC
RequestCycle, max steps
In RequestCycle.java, the steps() method has this code:
* final* *int* maxSteps = Short.MAX_VALUE;
Is there any way for me to override the maxSteps value?
Would it be reasonable to have getter/setter methods?
protected void setMaxSteps(int value)
protected int getMaxSteps()
Cheers,
Sean
Re: RequestCycle, max steps
Posted by Igor Vaynberg <ig...@gmail.com>.
fine by me
-igor
On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> max int is actually a pretty rediculous default in itself. How about
> setting it to 1,000 or even 100 or such?
>
> Eelco
>
> On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > Why would you want to do that? Sure, we can put a setter in there, but
> > it is really only meant to detect cycles.
> >
> > Eelco
> >
> >
> > On 6/18/07, Sean Sullivan <se...@seansullivan.com> wrote:
> > > In RequestCycle.java, the steps() method has this code:
> > >
> > > * final* *int* maxSteps = Short.MAX_VALUE;
> > >
> > > Is there any way for me to override the maxSteps value?
> > >
> > > Would it be reasonable to have getter/setter methods?
> > >
> > > protected void setMaxSteps(int value)
> > >
> > > protected int getMaxSteps()
> > >
> > >
> > > Cheers,
> > >
> > > Sean
> > >
> >
>
Re: RequestCycle, max steps
Posted by Sean Sullivan <se...@seansullivan.com>.
Yes, that works for me.
On 6/19/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> Ok. I set it to 100. Is that reasonable?
>
> Eelco
>
> On 6/19/07, Sean Sullivan <se...@seansullivan.com> wrote:
> > Short.MAX_VALUE is definitely too high.
> >
> > I'd love to see a lower value.
> >
> > Sean
> >
> > On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > >
> > > max int is actually a pretty rediculous default in itself. How about
> > > setting it to 1,000 or even 100 or such?
> > >
> > > Eelco
> > >
> > > On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > > > Why would you want to do that? Sure, we can put a setter in there,
> but
> > > > it is really only meant to detect cycles.
> > > >
> > > > Eelco
> > > >
> > > >
> > > > On 6/18/07, Sean Sullivan <se...@seansullivan.com> wrote:
> > > > > In RequestCycle.java, the steps() method has this code:
> > > > >
> > > > > * final* *int* maxSteps = Short.MAX_VALUE;
> > > > >
> > > > > Is there any way for me to override the maxSteps value?
> > > > >
> > > > > Would it be reasonable to have getter/setter methods?
> > > > >
> > > > > protected void setMaxSteps(int value)
> > > > >
> > > > > protected int getMaxSteps()
> > > > >
> > > > >
> > > > > Cheers,
> > > > >
> > > > > Sean
> > > > >
> > > >
> > >
> >
>
Re: RequestCycle, max steps
Posted by Eelco Hillenius <ee...@gmail.com>.
Ok. I set it to 100. Is that reasonable?
Eelco
On 6/19/07, Sean Sullivan <se...@seansullivan.com> wrote:
> Short.MAX_VALUE is definitely too high.
>
> I'd love to see a lower value.
>
> Sean
>
> On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
> >
> > max int is actually a pretty rediculous default in itself. How about
> > setting it to 1,000 or even 100 or such?
> >
> > Eelco
> >
> > On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > > Why would you want to do that? Sure, we can put a setter in there, but
> > > it is really only meant to detect cycles.
> > >
> > > Eelco
> > >
> > >
> > > On 6/18/07, Sean Sullivan <se...@seansullivan.com> wrote:
> > > > In RequestCycle.java, the steps() method has this code:
> > > >
> > > > * final* *int* maxSteps = Short.MAX_VALUE;
> > > >
> > > > Is there any way for me to override the maxSteps value?
> > > >
> > > > Would it be reasonable to have getter/setter methods?
> > > >
> > > > protected void setMaxSteps(int value)
> > > >
> > > > protected int getMaxSteps()
> > > >
> > > >
> > > > Cheers,
> > > >
> > > > Sean
> > > >
> > >
> >
>
Re: RequestCycle, max steps
Posted by Sean Sullivan <se...@seansullivan.com>.
Short.MAX_VALUE is definitely too high.
I'd love to see a lower value.
Sean
On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> max int is actually a pretty rediculous default in itself. How about
> setting it to 1,000 or even 100 or such?
>
> Eelco
>
> On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > Why would you want to do that? Sure, we can put a setter in there, but
> > it is really only meant to detect cycles.
> >
> > Eelco
> >
> >
> > On 6/18/07, Sean Sullivan <se...@seansullivan.com> wrote:
> > > In RequestCycle.java, the steps() method has this code:
> > >
> > > * final* *int* maxSteps = Short.MAX_VALUE;
> > >
> > > Is there any way for me to override the maxSteps value?
> > >
> > > Would it be reasonable to have getter/setter methods?
> > >
> > > protected void setMaxSteps(int value)
> > >
> > > protected int getMaxSteps()
> > >
> > >
> > > Cheers,
> > >
> > > Sean
> > >
> >
>
Re: RequestCycle, max steps
Posted by Eelco Hillenius <ee...@gmail.com>.
max int is actually a pretty rediculous default in itself. How about
setting it to 1,000 or even 100 or such?
Eelco
On 6/18/07, Eelco Hillenius <ee...@gmail.com> wrote:
> Why would you want to do that? Sure, we can put a setter in there, but
> it is really only meant to detect cycles.
>
> Eelco
>
>
> On 6/18/07, Sean Sullivan <se...@seansullivan.com> wrote:
> > In RequestCycle.java, the steps() method has this code:
> >
> > * final* *int* maxSteps = Short.MAX_VALUE;
> >
> > Is there any way for me to override the maxSteps value?
> >
> > Would it be reasonable to have getter/setter methods?
> >
> > protected void setMaxSteps(int value)
> >
> > protected int getMaxSteps()
> >
> >
> > Cheers,
> >
> > Sean
> >
>
Re: RequestCycle, max steps
Posted by Eelco Hillenius <ee...@gmail.com>.
Why would you want to do that? Sure, we can put a setter in there, but
it is really only meant to detect cycles.
Eelco
On 6/18/07, Sean Sullivan <se...@seansullivan.com> wrote:
> In RequestCycle.java, the steps() method has this code:
>
> * final* *int* maxSteps = Short.MAX_VALUE;
>
> Is there any way for me to override the maxSteps value?
>
> Would it be reasonable to have getter/setter methods?
>
> protected void setMaxSteps(int value)
>
> protected int getMaxSteps()
>
>
> Cheers,
>
> Sean
>
Re: RequestCycle, max steps
Posted by Igor Vaynberg <ig...@gmail.com>.
why would you want to do that? that is there only to detect run away loops.
-igor
On 6/18/07, Sean Sullivan <se...@seansullivan.com> wrote:
>
> In RequestCycle.java, the steps() method has this code:
>
> * final* *int* maxSteps = Short.MAX_VALUE;
>
> Is there any way for me to override the maxSteps value?
>
> Would it be reasonable to have getter/setter methods?
>
> protected void setMaxSteps(int value)
>
> protected int getMaxSteps()
>
>
> Cheers,
>
> Sean
>