You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by we...@apache.org on 2022/07/20 03:02:55 UTC
[dolphinscheduler] branch dev updated: [Improvement][Task Plugin]Refactor JupyterParameters.java with lombok (#11045)
This is an automated email from the ASF dual-hosted git repository.
wenjun pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 2f0d907bcb [Improvement][Task Plugin]Refactor JupyterParameters.java with lombok (#11045)
2f0d907bcb is described below
commit 2f0d907bcb2ab7f78cbc0bddf4f894041623c26b
Author: Eric Gao <er...@gmail.com>
AuthorDate: Wed Jul 20 11:02:47 2022 +0800
[Improvement][Task Plugin]Refactor JupyterParameters.java with lombok (#11045)
* [Improvement][Task Plugin]Refactor JupyterParameters.java with lombok (#11040)
---
.../plugin/task/jupyter/JupyterParameters.java | 100 ++-------------------
1 file changed, 6 insertions(+), 94 deletions(-)
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterParameters.java
index 80f9e6ca72..dd38049492 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterParameters.java
@@ -17,6 +17,9 @@
package org.apache.dolphinscheduler.plugin.task.jupyter;
+import lombok.Getter;
+import lombok.Setter;
+import lombok.ToString;
import org.apache.dolphinscheduler.plugin.task.api.model.ResourceInfo;
import org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters;
@@ -25,6 +28,9 @@ import java.util.List;
/**
* jupyter parameters
*/
+@Getter
+@Setter
+@ToString
public class JupyterParameters extends AbstractParameters {
/**
@@ -77,86 +83,6 @@ public class JupyterParameters extends AbstractParameters {
*/
private List<ResourceInfo> resourceList;
- public String getCondaEnvName() {
- return condaEnvName;
- }
-
- public void setCondaEnvName(String condaEnvName) {
- this.condaEnvName = condaEnvName;
- }
-
- public String getInputNotePath() {
- return inputNotePath;
- }
-
- public void setInputNotePath(String inputNotePath) {
- this.inputNotePath = inputNotePath;
- }
-
- public String getOutputNotePath() {
- return outputNotePath;
- }
-
- public void setOutputNotePath(String outputNotePath) {
- this.outputNotePath = outputNotePath;
- }
-
- public String getParameters() {
- return parameters;
- }
-
- public void setParameters(String parameters) {
- this.parameters = parameters;
- }
-
- public String getKernel() {
- return kernel;
- }
-
- public void setKernel(String kernel) {
- this.kernel = kernel;
- }
-
- public String getEngine() {
- return engine;
- }
-
- public void setEngine(String engine) {
- this.engine = engine;
- }
-
- public String getExecutionTimeout() {
- return executionTimeout;
- }
-
- public void setExecutionTimeout(String executionTimeout) {
- this.executionTimeout = executionTimeout;
- }
-
- public String getStartTimeout() {
- return startTimeout;
- }
-
- public void setStartTimeout(String startTimeout) {
- this.startTimeout = startTimeout;
- }
-
- public String getOthers() {
- return others;
- }
-
- public void setOthers(String others) {
- this.others = others;
- }
-
- public List<ResourceInfo> getResourceList() {
- return resourceList;
- }
-
- public void setResourceList(List<ResourceInfo> resourceList) {
- this.resourceList = resourceList;
- }
-
@Override
public List<ResourceInfo> getResourceFilesList() {
return resourceList;
@@ -167,18 +93,4 @@ public class JupyterParameters extends AbstractParameters {
return condaEnvName != null && inputNotePath != null && outputNotePath != null;
}
- @Override
- public String toString() {
- return "JupyterParameters{" +
- "condaEnvName='" + condaEnvName + '\'' +
- ", inputNotePath='" + inputNotePath + '\'' +
- ", outputNotePath='" + outputNotePath + '\'' +
- ", parameters='" + parameters + '\'' +
- ", kernel='" + kernel + '\'' +
- ", engine='" + engine + '\'' +
- ", executionTimeout=" + executionTimeout +
- ", startTimeout=" + startTimeout +
- ", others='" + others + '\'' +
- '}';
- }
}