[jira] [Commented] (KAFKA-2238) KafkaMetricsConfig cannot be configured in broker (KafkaConfig)

["Aditya Auradkar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582679#comment-14582679 ] 

Aditya Auradkar commented on KAFKA-2238:
----------------------------------------

[~junrao][~nehanarkhede] Can one of you review this?

> KafkaMetricsConfig cannot be configured in broker (KafkaConfig)
> ---------------------------------------------------------------
>
>                 Key: KAFKA-2238
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2238
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Aditya Auradkar
>            Assignee: Aditya Auradkar
>         Attachments: KAFKA-2238.patch
>
>
> All metrics config values are not included in KafkaConfig and consequently cannot be configured into the brokers. This is because the KafkaMetricsReporter is passed a properties object generated by calling toProps on KafkaConfig
> KafkaMetricsReporter.startReporters(new VerifiableProperties(serverConfig.toProps))
> However, KafkaConfig never writes these values into the properties object and hence these aren't configurable. The defaults always apply
> Add the following metrics to KafkaConfig
> kafka.metrics.reporters, kafka.metrics.polling.interval.secs, kafka.csv.metrics.reporter.enabled, kafka.csv.metrics.dir



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)