You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/15 11:16:00 UTC

[jira] [Commented] (NIFI-4619) AWSCredentialsProviderControllerService Does Not Apply Expression Language

    [ https://issues.apache.org/jira/browse/NIFI-4619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292359#comment-16292359 ] 

ASF GitHub Bot commented on NIFI-4619:
--------------------------------------

GitHub user mgaido91 opened a pull request:

    https://github.com/apache/nifi/pull/2344

    NIFI-4619: Enable expression language on AWSCredentialsProviderControllerService properties

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? N/A 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? N/A
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? N/A
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? N/A
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? N/A
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/nifi NIFI-4619

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2344
    
----
commit 1888a1b83bd1813d296ae3fd2c789b86b973385e
Author: Marco Gaido <mg...@hortonworks.com>
Date:   2017-12-15T10:06:13Z

    NIFI-4619: Enable expression language on AWSCredentialsProviderControllerService properties

----


> AWSCredentialsProviderControllerService Does Not Apply Expression Language
> --------------------------------------------------------------------------
>
>                 Key: NIFI-4619
>                 URL: https://issues.apache.org/jira/browse/NIFI-4619
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.1.0, 1.2.0, 1.1.1, 1.0.1, 1.3.0, 1.4.0
>            Reporter: James Wing
>            Priority: Minor
>
> As [mentioned on the users mailing list|https://mail-archives.apache.org/mod_mbox/nifi-users/201711.mbox/%3CCAHdHwgxOFF_ExRXkK7j3mc3X8g3Qpq6fbQNge9p7AWu60uk61w%40mail.gmail.com%3E], the AWSCredentialsProviderControllerService does not actually apply expression language for properties documented as supporting expression language (Access Key, Secret Key, Profile Name).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)