[GitHub] [calcite] danny0405 commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r417857098



##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -230,6 +230,18 @@ public RelDataTypeFactory getTypeFactory() {
     return cluster.getTypeFactory();
   }
 
+  /** Return the RelFactories Struct. */
+  public RelFactories.Struct getRelFactoriesStruct() {
+    return this.struct;
+  }
+
+  /** Set the RelFactories Struct. Conventions can use a different RelFactories struct to
+   *  create physical RelNode.*/
+  public RelBuilder setRelFactoriesStruct(RelFactories.Struct newStruct) {
+    this.struct = newStruct;
+    return this;
+  }
+

Review comment:
       Let's move the config to `RelBuilder.Config`, we do not really set or get anything on the `RelBuilder` because it's configuration should always be immutable. An immutable configuration makes the Object more deterministic and we know its state when we create it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org