You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/03/04 18:49:50 UTC

[royale-asjs] branch develop updated: jewel-textinpuntbase: internal refactor to use "input" instead of element

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 9db1308  jewel-textinpuntbase: internal refactor to use "input" instead of element
9db1308 is described below

commit 9db1308121e29e57a4c8e153e1289ea3ba1ca7dc
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Wed Mar 4 19:49:41 2020 +0100

    jewel-textinpuntbase: internal refactor to use "input" instead of element
---
 .../src/main/royale/org/apache/royale/jewel/TextArea.as      |  2 +-
 .../src/main/royale/org/apache/royale/jewel/TextInput.as     |  2 +-
 .../royale/jewel/supportClasses/textinput/TextInputBase.as   | 12 ++++++------
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextArea.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextArea.as
index c935671..657ba9b 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextArea.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextArea.as
@@ -124,7 +124,7 @@ package org.apache.royale.jewel
             //attach input handler to dispatch royale change event when user write in textinput
             //goog.events.listen(element, 'change', killChangeHandler);
             goog.events.listen(input, 'input', textChangeHandler);
-            goog.events.listen(element, 'keypress', enterEventHandler);
+            goog.events.listen(input, 'keypress', enterEventHandler, true);
             
             positioner = document.createElement('div') as WrappedHTMLElement;
             
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextInput.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextInput.as
index 8c05675..28173a4 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextInput.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/TextInput.as
@@ -67,7 +67,7 @@ package org.apache.royale.jewel
             //attach input handler to dispatch royale change event when user write in textinput
             //goog.events.listen(element, 'change', killChangeHandler);
             goog.events.listen(input, 'input', textChangeHandler);
-            goog.events.listen(element, 'keypress', enterEventHandler, true);
+            goog.events.listen(input, 'keypress', enterEventHandler, true);
             
             positioner = document.createElement('div') as WrappedHTMLElement;
             
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
index 802db64..1c1c77e 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/textinput/TextInputBase.as
@@ -105,7 +105,7 @@ package org.apache.royale.jewel.supportClasses.textinput
             }
             COMPILE::JS
             {
-            return (element as HTMLInputElement).value;
+            return input.value;
             }
 		}
         /**
@@ -122,7 +122,7 @@ package org.apache.royale.jewel.supportClasses.textinput
             }
             COMPILE::JS
             {
-            (element as HTMLInputElement).value = value;
+            input.value = value;
             dispatchEvent(new Event('textChange'));
             }
 		}
@@ -145,7 +145,7 @@ package org.apache.royale.jewel.supportClasses.textinput
             }
             COMPILE::JS
             {
-            return (element as HTMLInputElement).value;
+            return input.value;
             }
 		}
         /**
@@ -160,7 +160,7 @@ package org.apache.royale.jewel.supportClasses.textinput
             }
             COMPILE::JS
             {
-            (element as HTMLInputElement).value = value;
+            input.value = value;
             dispatchEvent(new Event('textChange'));
             }
 		}
@@ -245,7 +245,7 @@ package org.apache.royale.jewel.supportClasses.textinput
 		{
 			_positioner = value;
             _positioner.royale_wrapper = this;
-			_positioner.appendChild(element);
+			_positioner.appendChild(input);
 		}
 
         /**
@@ -260,7 +260,7 @@ package org.apache.royale.jewel.supportClasses.textinput
 		{
             COMPILE::JS
             {
-                element.focus();
+                input.focus();
             }
         }
 	}