[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2845: FINERACT-1841 Fix Duplicated journal entries when a chargeback happens

[GitBox <gi...@apache.org>]

josehernandezfintecheandomx commented on code in PR #2845:
URL: https://github.com/apache/fineract/pull/2845#discussion_r1058543441


##########
fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java:
##########
@@ -354,7 +354,7 @@ public InteropQuoteResponseData createQuote(@NotNull JsonCommand command) {
 
         final BigDecimal fee;
         if (transactionType.isDebit()) {
-            fee = savingsAccount.calculateWithdrawalFee(request.getAmount().getAmount());
+            fee = savingsAccount.calculateTransactionFee(request.getAmount().getAmount());

Review Comment:
   Done removed!



##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java:
##########
@@ -223,12 +223,12 @@ private Charge(final String name, final BigDecimal amount, final String currency
                         .failWithCodeNoParameterAddedToErrorCode("not.allowed.charge.calculation.type.for.savings");
             }
 
-            if (!(ChargeTimeType.fromInt(getChargeTimeType()).isWithdrawalFee()
-                    || ChargeTimeType.fromInt(getChargeTimeType()).isSavingsNoActivityFee())
+            final ChargeTimeType chargeTimeType = ChargeTimeType.fromInt(getChargeTimeType());

Review Comment:
   Done removed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org