You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2026/03/01 17:55:23 UTC
(airflow) branch fix-ambiguity-of-agent-instructions created (now 0bb1bdfebb0)
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch fix-ambiguity-of-agent-instructions
in repository https://gitbox.apache.org/repos/asf/airflow.git
at 0bb1bdfebb0 Fix ambiguity of AGENT instructions
This branch includes the following new commits:
new 0bb1bdfebb0 Fix ambiguity of AGENT instructions
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(airflow) 01/01: Fix ambiguity of AGENT instructions
Posted by po...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch fix-ambiguity-of-agent-instructions
in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 0bb1bdfebb0f8f42a17e9433106c9f3e2966cefe
Author: Jarek Potiuk <ja...@potiuk.com>
AuthorDate: Sun Mar 1 18:53:48 2026 +0100
Fix ambiguity of AGENT instructions
The prek commants were somewaht ambiguous, depending on how prek
was installed. Adding explicit --hook-stage makes it unambiguous.
---
AGENTS.md | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/AGENTS.md b/AGENTS.md
index 05f76fa45ac..c867019380e 100644
--- a/AGENTS.md
+++ b/AGENTS.md
@@ -17,9 +17,10 @@
- **Run a Python script:** `breeze run python dev/my_script.py`
- **Run Airflow CLI:** `breeze run airflow dags list`
- **Type-check:** `breeze run mypy path/to/code`
-- **Lint/format (runs on host):** `prek run --ref-from <target_branch>`
- **Lint with ruff only:** `prek run ruff --ref-from <target_branch>`
- **Format with ruff only:** `prek run ruff-format --ref-from <target_branch>`
+- **Run regular(fast) static checks:** `prek run --ref-from <target_branch> --hook-stage pre-commit`
+- **Run manual(slower) checks:** `prek run --ref-from <target_branch> --hook-stage manual`
`<target_branch>` is the branch the PR will be merged into — usually `main`, but could be
`v3-1-test` when creating a PR for the 3.1 branch.
@@ -110,9 +111,11 @@ code review checklist in [`.github/instructions/code-review.instructions.md`](.g
API correctness, and AI-generated code signals. Fix any violations before pushing.
3. Confirm the code follows the project's coding standards and architecture boundaries
described in this file.
-4. Run static checks (`prek run --ref-from <target_branch>`) and fix any failures.
-5. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
-6. Check for security issues — no secrets, no injection vulnerabilities, no unsafe patterns.
+4. Run regular (fast) static checks (`prek run --ref-from <target_branch> --hook-stage pre-commit`)
+ and fix any failures.
+5. Run manual (slower) checks (`prek run --ref-from <target_branch> --hook-stage manual`) and fix any failures.
+6. Run relevant tests (`breeze run pytest <path> -xvs`) and confirm they pass.
+7. Check for security issues — no secrets, no injection vulnerabilities, no unsafe patterns.
Then push the branch to the user's fork remote and open the PR creation page in the browser
with the body pre-filled (including the generative AI disclosure already checked):