You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 09:31:28 UTC
[jira] [Created] (CASSANDRA-4076) Remove
get{Indexed,Sliced}ReadBufferSizeInKB methods
Remove get{Indexed,Sliced}ReadBufferSizeInKB methods
----------------------------------------------------
Key: CASSANDRA-4076
URL: https://issues.apache.org/jira/browse/CASSANDRA-4076
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 1.0.0
Reporter: Sylvain Lebresne
Priority: Trivial
Since CASSANDRA-3171, the DatabaseDescriptor.get{Indexed,Sliced}ReadBufferSizeInKB methods are dead code (they are used as bufferSize argument to SSTableReader.getFileDataInput but that method ignore the argument). This means in particular that we can remove the configuration option sliced_buffer_size_in_kb (we shouldn't do that in 1.0 which is why I targeted to 1.1.0, though we could add a message in 1.0 that this argument is ignored).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4076) Remove
get{Indexed,Sliced}ReadBufferSizeInKB methods
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4076:
----------------------------------------
Fix Version/s: 1.1.0
> Remove get{Indexed,Sliced}ReadBufferSizeInKB methods
> ----------------------------------------------------
>
> Key: CASSANDRA-4076
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4076
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.1.0
>
>
> Since CASSANDRA-3171, the DatabaseDescriptor.get{Indexed,Sliced}ReadBufferSizeInKB methods are dead code (they are used as bufferSize argument to SSTableReader.getFileDataInput but that method ignore the argument). This means in particular that we can remove the configuration option sliced_buffer_size_in_kb (we shouldn't do that in 1.0 which is why I targeted to 1.1.0, though we could add a message in 1.0 that this argument is ignored).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4076) Remove
get{Indexed,Sliced}ReadBufferSizeInKB methods
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242371#comment-13242371 ]
Jonathan Ellis commented on CASSANDRA-4076:
-------------------------------------------
+1
> Remove get{Indexed,Sliced}ReadBufferSizeInKB methods
> ----------------------------------------------------
>
> Key: CASSANDRA-4076
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4076
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.1.0
>
> Attachments: 4076.txt
>
>
> Since CASSANDRA-3171, the DatabaseDescriptor.get{Indexed,Sliced}ReadBufferSizeInKB methods are dead code (they are used as bufferSize argument to SSTableReader.getFileDataInput but that method ignore the argument). This means in particular that we can remove the configuration option sliced_buffer_size_in_kb (we shouldn't do that in 1.0 which is why I targeted to 1.1.0, though we could add a message in 1.0 that this argument is ignored).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4076) Remove
get{Indexed,Sliced}ReadBufferSizeInKB methods
Posted by "Sylvain Lebresne (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne resolved CASSANDRA-4076.
-----------------------------------------
Resolution: Fixed
Reviewer: jbellis
Assignee: Sylvain Lebresne
Committed, thanks
> Remove get{Indexed,Sliced}ReadBufferSizeInKB methods
> ----------------------------------------------------
>
> Key: CASSANDRA-4076
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4076
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.1.0
>
> Attachments: 4076.txt
>
>
> Since CASSANDRA-3171, the DatabaseDescriptor.get{Indexed,Sliced}ReadBufferSizeInKB methods are dead code (they are used as bufferSize argument to SSTableReader.getFileDataInput but that method ignore the argument). This means in particular that we can remove the configuration option sliced_buffer_size_in_kb (we shouldn't do that in 1.0 which is why I targeted to 1.1.0, though we could add a message in 1.0 that this argument is ignored).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4076) Remove
get{Indexed,Sliced}ReadBufferSizeInKB methods
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4076:
----------------------------------------
Attachment: 4076.txt
Trivial patch attached. I'd like to get that in 1.1.0 just before this remove a (useless) option from the cassandra.yaml file and I want to avoid doing that on a minor release. Besides, this really just remove dead code.
> Remove get{Indexed,Sliced}ReadBufferSizeInKB methods
> ----------------------------------------------------
>
> Key: CASSANDRA-4076
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4076
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Sylvain Lebresne
> Priority: Trivial
> Fix For: 1.1.0
>
> Attachments: 4076.txt
>
>
> Since CASSANDRA-3171, the DatabaseDescriptor.get{Indexed,Sliced}ReadBufferSizeInKB methods are dead code (they are used as bufferSize argument to SSTableReader.getFileDataInput but that method ignore the argument). This means in particular that we can remove the configuration option sliced_buffer_size_in_kb (we shouldn't do that in 1.0 which is why I targeted to 1.1.0, though we could add a message in 1.0 that this argument is ignored).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira