You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "TOMASHEVSKIYIVAN (via GitHub)" <gi...@apache.org> on 2024/09/27 07:53:06 UTC
[PR] weact stm32h743vit6 usbconsole fix [nuttx]
TOMASHEVSKIYIVAN opened a new pull request, #13667:
URL: https://github.com/apache/nuttx/pull/13667
fix previous problemc
added defconfig for weact-stm32h743:nshusb
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] weact stm32h743vit6 usbconsole fix [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #13667:
URL: https://github.com/apache/nuttx/pull/13667#discussion_r1778295588
##########
boards/arm/stm32h7/weact-stm32h743/src/weact-stm32h743.h:
##########
@@ -46,6 +49,54 @@
# endif
#endif
+/* Can't support USB host or device features if USB OTG FS is not enabled */
+
+#ifndef CONFIG_STM32H7_OTGFS
+# undef HAVE_USBDEV
Review Comment:
why need define HAVE_XXX maros?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] weact stm32h743vit6 usbconsole fix [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #13667:
URL: https://github.com/apache/nuttx/pull/13667#discussion_r1778826942
##########
boards/arm/stm32h7/weact-stm32h743/src/weact-stm32h743.h:
##########
@@ -46,6 +49,54 @@
# endif
#endif
+/* Can't support USB host or device features if USB OTG FS is not enabled */
+
+#ifndef CONFIG_STM32H7_OTGFS
+# undef HAVE_USBDEV
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] weact stm32h743vit6 usbconsole fix [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #13667:
URL: https://github.com/apache/nuttx/pull/13667#discussion_r1778357732
##########
boards/arm/stm32h7/weact-stm32h743/src/weact-stm32h743.h:
##########
@@ -46,6 +49,54 @@
# endif
#endif
+/* Can't support USB host or device features if USB OTG FS is not enabled */
+
+#ifndef CONFIG_STM32H7_OTGFS
+# undef HAVE_USBDEV
Review Comment:
but I think no code reference HAVE_XXXX in nuttx code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] weact stm32h743vit6 usbconsole fix [nuttx]
Posted by "TOMASHEVSKIYIVAN (via GitHub)" <gi...@apache.org>.
TOMASHEVSKIYIVAN closed pull request #13667: weact stm32h743vit6 usbconsole fix
URL: https://github.com/apache/nuttx/pull/13667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] weact stm32h743vit6 usbconsole fix [nuttx]
Posted by "TOMASHEVSKIYIVAN (via GitHub)" <gi...@apache.org>.
TOMASHEVSKIYIVAN commented on code in PR #13667:
URL: https://github.com/apache/nuttx/pull/13667#discussion_r1778367837
##########
boards/arm/stm32h7/weact-stm32h743/src/weact-stm32h743.h:
##########
@@ -46,6 +49,54 @@
# endif
#endif
+/* Can't support USB host or device features if USB OTG FS is not enabled */
+
+#ifndef CONFIG_STM32H7_OTGFS
+# undef HAVE_USBDEV
Review Comment:
I found code-like in nuttx/boards/arm/stm32h7/linum-stm32h753bi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] weact stm32h743vit6 usbconsole fix [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #13667:
URL: https://github.com/apache/nuttx/pull/13667#issuecomment-2378673596
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
**No, this PR does not meet the NuttX requirements.**
**Missing Information:**
* **Summary:**
* **Why is the change necessary?** What problem does it fix?
* **What functional part of the code is being changed?** Be specific (e.g., USB driver, networking stack, build system).
* **How does the change work?** Provide technical details about the implementation.
* **Related Issues/PRs:** Link any relevant issues or pull requests.
* **Impact:**
* Most of the impact sections are left blank. You **must** address each point, even if the answer is "NO" (provide a brief explanation if necessary).
* **Testing:**
* **Insufficient Detail:** "fix previous problemc" and "added defconfig" are not descriptive enough.
* **Missing Logs:** You need to provide actual testing logs from before and after the change to demonstrate the issue and the fix.
**Recommendations:**
1. **Expand the Summary:** Clearly articulate the problem, solution, and technical details of your change.
2. **Complete the Impact Section:** Thoroughly address each impact point, even if the answer is "NO."
3. **Provide Detailed Testing Information:** Include:
* Specific build host and target details.
* Clear and complete testing logs from before and after the change.
* Steps to reproduce the issue (if applicable).
**Remember:** A well-written PR makes it easier for maintainers to understand and review your changes, increasing the likelihood of your contribution being accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] weact stm32h743vit6 usbconsole fix [nuttx]
Posted by "TOMASHEVSKIYIVAN (via GitHub)" <gi...@apache.org>.
TOMASHEVSKIYIVAN commented on code in PR #13667:
URL: https://github.com/apache/nuttx/pull/13667#discussion_r1778313192
##########
boards/arm/stm32h7/weact-stm32h743/src/weact-stm32h743.h:
##########
@@ -46,6 +49,54 @@
# endif
#endif
+/* Can't support USB host or device features if USB OTG FS is not enabled */
+
+#ifndef CONFIG_STM32H7_OTGFS
+# undef HAVE_USBDEV
Review Comment:
if not configured OTG FS then there should be no chance to use it in compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] weact stm32h743vit6 usbconsole fix [nuttx]
Posted by "TOMASHEVSKIYIVAN (via GitHub)" <gi...@apache.org>.
TOMASHEVSKIYIVAN closed pull request #13667: weact stm32h743vit6 usbconsole fix
URL: https://github.com/apache/nuttx/pull/13667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org