[GitHub] [commons-compress] PeterAlfreadLee edited a comment on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives

[GitBox <gi...@apache.org>]

PeterAlfreadLee edited a comment on issue #87: COMPRESS-124 : Add support for extracting sparse entries from tar archives
URL: https://github.com/apache/commons-compress/pull/87#issuecomment-558989557
 
 
   Code just pushed basing on reviews of @tcurdt and @melloware .
   Exception for one review opinion :
   Is creating a separate class `TarArchiveSparseInputStream` a good idea or not?
   
   Of course I can make `TarArchiveInputStream` be able to handle sparse entries, therefore I need to modify the `read()` and `skip()` in TarArchiveInputStream when we are reading sparse entries.
   
   The reason why I create a new class `TarArchiveSparseInputStream` is that I don't want to modify `TarArchiveInputStream` too much. I want to try my best to keep the `TarArchiveInputStream` as the original logic as much as possible.
   
   With a separate `TarArchiveSparseInputStream`, I can replace the input stream to a new `TarArchiveSparseInputStream`. I don't need to modify the `read()` or `skip()` in `TarArchiveInputStream`.
   
   I'm not sure if creating a separate `TarArchiveSparseInputStream` is a good idea or not.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services