You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "kirill-stepanishin (via GitHub)" <gi...@apache.org> on 2025/10/10 16:55:58 UTC

[PR] Integrate Go driver examples into automated build process [tinkerpop]

kirill-stepanishin opened a new pull request, #3239:
URL: https://github.com/apache/tinkerpop/pull/3239

   ## Summary
   
   Integrates Go Gremlin examples into CI to ensure they remain functional in future releases. Examples now execute automatically after integration tests and fail the build if broken.
   
   ## Changes Made
   
   - Added example execution to gremlin-go-integration-tests container in docker-compose.yml
   - Made server URLs configurable via environment variables (replaces hardcoded localhost:8182)
   - Use specialized labels to isolate test data
   - Replaced port placeholder logic with getEnvOrDefaultString() helper function (mimic existing integration tests)
   - Build fails if any example fails to execute


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Integrate Go driver examples into automated build process [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #3239:
URL: https://github.com/apache/tinkerpop/pull/3239#issuecomment-3411884383

   Please add a changelog entry thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Integrate Go driver examples into automated build process [tinkerpop]

Posted by "andreachild (via GitHub)" <gi...@apache.org>.
andreachild commented on PR #3239:
URL: https://github.com/apache/tinkerpop/pull/3239#issuecomment-3411923296

   VOTE +1 pending changelog entry


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Integrate Go driver examples into automated build process [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #3239:
URL: https://github.com/apache/tinkerpop/pull/3239#issuecomment-3417172454

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Integrate Go driver examples into automated build process [tinkerpop]

Posted by "kirill-stepanishin (via GitHub)" <gi...@apache.org>.
kirill-stepanishin commented on PR #3239:
URL: https://github.com/apache/tinkerpop/pull/3239#issuecomment-3412112340

   > VOTE +1 pending changelog entry
   
   Added a generic changelog entry for all GLV examples in https://github.com/apache/tinkerpop/pull/3231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Integrate Go driver examples into automated build process [tinkerpop]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3239:
URL: https://github.com/apache/tinkerpop/pull/3239#issuecomment-3392575108

   ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 74.24%. Comparing base ([`9b46b67`](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`80f7885`](https://app.codecov.io/gh/apache/tinkerpop/commit/80f788509c6ea2747b85b3529699e17690db1346?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 385 commits behind head on 3.7-dev.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             3.7-dev    #3239      +/-   ##
   =============================================
   - Coverage      76.14%   74.24%   -1.91%     
   =============================================
     Files           1084       28    -1056     
     Lines          65160     5917   -59243     
     Branches        7285        0    -7285     
   =============================================
   - Hits           49616     4393   -45223     
   + Misses         12839     1322   -11517     
   + Partials        2705      202    -2503     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3239?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Integrate Go driver examples into automated build process [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #3239:
URL: https://github.com/apache/tinkerpop/pull/3239#issuecomment-3554539515

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Integrate Go driver examples into automated build process [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #3239:
URL: https://github.com/apache/tinkerpop/pull/3239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org