You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2021/12/23 08:48:54 UTC
[httpcomponents-client] branch 5.1.x updated (4765f93 -> 7d0ad1a)
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a change to branch 5.1.x
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git.
discard 4765f93 Upgraded HttpCore to version 5.1.3
discard f5ed2cd Bug fix: Incorrect connection validity check in the async connection manager can cause an IllegalStateException and lead to a connection leak. Treat closed connections as valid due to the connection open check being inherently racy
discard 2119b47 Bump log4j to 2.16.0
new cac4358 Bump log4j to 2.12.3
new 712658b Bug fix: Incorrect connection validity check in the async connection manager can cause an IllegalStateException and lead to a connection leak. Treat closed connections as valid due to the connection open check being inherently racy
new 7d0ad1a Upgraded HttpCore to version 5.1.3
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (4765f93)
\
N -- N -- N refs/heads/5.1.x (7d0ad1a)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[httpcomponents-client] 01/03: Bump log4j to 2.12.3
Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch 5.1.x
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git
commit cac4358e93ab0087293e8e2288a4213609a40d29
Author: mxd4 <ma...@ultimatesoftware.com>
AuthorDate: Wed Dec 15 11:04:15 2021 +0100
Bump log4j to 2.12.3
---
pom.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pom.xml b/pom.xml
index 6aadcb9..870f08d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -63,7 +63,7 @@
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
<httpcore.version>5.1.2</httpcore.version>
- <log4j.version>2.9.1</log4j.version>
+ <log4j.version>2.12.3</log4j.version>
<commons-codec.version>1.15</commons-codec.version>
<conscrypt.version>2.2.1</conscrypt.version>
<ehcache.version>3.4.0</ehcache.version>
@@ -385,4 +385,4 @@
</plugins>
</reporting>
-</project>
\ No newline at end of file
+</project>
[httpcomponents-client] 03/03: Upgraded HttpCore to version 5.1.3
Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch 5.1.x
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git
commit 7d0ad1aed4a2c61034022c358d24dc3f289a5a38
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Wed Dec 22 23:32:23 2021 +0100
Upgraded HttpCore to version 5.1.3
---
pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index 870f08d..7a94930 100644
--- a/pom.xml
+++ b/pom.xml
@@ -62,7 +62,7 @@
<properties>
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
- <httpcore.version>5.1.2</httpcore.version>
+ <httpcore.version>5.1.3</httpcore.version>
<log4j.version>2.12.3</log4j.version>
<commons-codec.version>1.15</commons-codec.version>
<conscrypt.version>2.2.1</conscrypt.version>
[httpcomponents-client] 02/03: Bug fix: Incorrect connection validity check in the async connection manager can cause an IllegalStateException and lead to a connection leak. Treat closed connections as valid due to the connection open check being inherently racy
Posted by ol...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
olegk pushed a commit to branch 5.1.x
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git
commit 712658b1b029d9d5677c04ba6e6776ab374f566c
Author: Oleg Kalnichevski <ol...@apache.org>
AuthorDate: Thu Dec 16 20:40:04 2021 +0100
Bug fix: Incorrect connection validity check in the async connection manager can cause an IllegalStateException and lead to a connection leak. Treat closed connections as valid due to the connection open check being inherently racy
---
.../client5/http/impl/nio/PoolingAsyncClientConnectionManager.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
index b7c609f..32617d6 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
@@ -79,7 +79,6 @@ import org.apache.hc.core5.pool.StrictConnPool;
import org.apache.hc.core5.reactor.Command;
import org.apache.hc.core5.reactor.ConnectionInitiator;
import org.apache.hc.core5.util.Args;
-import org.apache.hc.core5.util.Asserts;
import org.apache.hc.core5.util.Identifiable;
import org.apache.hc.core5.util.TimeValue;
import org.apache.hc.core5.util.Timeout;
@@ -545,8 +544,9 @@ public class PoolingAsyncClientConnectionManager implements AsyncClientConnectio
PoolEntry<HttpRoute, ManagedAsyncClientConnection> getValidatedPoolEntry() {
final PoolEntry<HttpRoute, ManagedAsyncClientConnection> poolEntry = getPoolEntry();
- final ManagedAsyncClientConnection connection = poolEntry.getConnection();
- Asserts.check(connection != null && connection.isOpen(), "Endpoint is not connected");
+ if (poolEntry.getConnection() == null) {
+ throw new ConnectionShutdownException();
+ }
return poolEntry;
}