You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2020/05/18 01:33:00 UTC
[jira] [Resolved] (YUNIKORN-153) Move updateRequest creation out of
resource.go
[ https://issues.apache.org/jira/browse/YUNIKORN-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wilfred Spiegelenburg resolved YUNIKORN-153.
--------------------------------------------
Fix Version/s: 0.9
Resolution: Fixed
Merged the changes, thank you [~Huang Ting Yao] for the contribution
> Move updateRequest creation out of resource.go
> ----------------------------------------------
>
> Key: YUNIKORN-153
> URL: https://issues.apache.org/jira/browse/YUNIKORN-153
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Ting Yao,Huang
> Priority: Minor
> Labels: newbie, pull-request-available
> Fix For: 0.9
>
>
> In the resource.go file we have a number of functions that are used to create {{si.UpdateRequest}}.
> these functions do not belong in the resource code and should be moved to a separate file with the test that belong to it also moved out of the resource_test.go file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org