You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Fedotov (JIRA)" <ji...@apache.org> on 2007/02/22 10:24:06 UTC
[jira] Created: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
[drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
-----------------------------------------------------------------------------------------------------
Key: HARMONY-3225
URL: https://issues.apache.org/jira/browse/HARMONY-3225
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Alexei Fedotov
The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] subroutine inlining and verification
Posted by Alexei Fedotov <al...@gmail.com>.
Hello Gregory,
Pavel and I have completed reviewing subroutine verification code.
Could you please take care of commit?
Thank you in advance,
Alexei
On 4/10/07, Alexei Fedotov (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Alexei Fedotov updated HARMONY-3225:
> ------------------------------------
>
> Description: The patch fixes all verification problems found by validation test suite. (was: The code checks the index of an instruction which follows jsr and founds that it is not in range.)
>
> > [drlvm][verifier] subroutine inlining and verification
> > ------------------------------------------------------
> >
> > Key: HARMONY-3225
> > URL: https://issues.apache.org/jira/browse/HARMONY-3225
> > Project: Harmony
> > Issue Type: Improvement
> > Components: DRLVM
> > Reporter: Alexei Fedotov
> > Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
> >
> >
> > The patch fixes all verification problems found by validation test suite.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
With best regards,
Alexei,
ESSD, Intel
[jira] Assigned: (HARMONY-3225) [drlvm][verifier] subroutine
inlining and verification
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-3225:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][verifier] subroutine inlining and verification
> ------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assigned To: Gregory Shimansky
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
>
>
> The patch fixes all verification problems found by validation test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3225) [drlvm][verifier] subroutine inlining
and verification
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov closed HARMONY-3225.
-----------------------------------
Thanks, the patch works as expected.
> [drlvm][verifier] subroutine inlining and verification
> ------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assigned To: Gregory Shimansky
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
>
>
> The patch fixes all verification problems found by validation test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Attachment: sub_ver.patch
Attached the patch.
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Attachment: test.patch
sub_ver_formatting.patch
vf_interface.patch
Added the latest interface, verifier and regression test suite patches.
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3225) [drlvm][verifier] subroutine
inlining and verification
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3225.
----------------------------------------
Resolution: Fixed
Patch is applied at 528575. Please check that it was applied as expected.
> [drlvm][verifier] subroutine inlining and verification
> ------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Assigned To: Gregory Shimansky
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
>
>
> The patch fixes all verification problems found by validation test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] subroutine
inlining and verification
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Description: The patch fixes all verification problems found by validation test suite. (was: The code checks the index of an instruction which follows jsr and founds that it is not in range.)
> [drlvm][verifier] subroutine inlining and verification
> ------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
>
>
> The patch fixes all verification problems found by validation test suite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Attachment: LastJsrTest.patch
The patch contains a new file with a test
svn add src/test/regression/H3225/LastJsrTest.j
The test fails on DRLVM and passes on RI.
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: LastJsrTest.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] subroutine
inlining and verification
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Issue Type: Improvement (was: Bug)
Summary: [drlvm][verifier] subroutine inlining and verification (was: [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage)
> [drlvm][verifier] subroutine inlining and verification
> ------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Attachment: sub_ver.patch
formatted.zip
format.sh
The first file automatically formats old sources in Pavel's style and new sources in Apache's style. The archive contains formatted sources. The patch is intended for review and measures the difference between automatically formatted sources, it cannot be applied directly to the current source tree.
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, LastJsrTest.patch, sub_ver.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Attachment: (was: sub_ver.patch)
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Attachment: interface.patch
A patch interface.patch patches an interface between a class loader and a verifier
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Attachment: sub_ver_2.patch
Three review sessions passed.
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487800 ]
Alexei Fedotov commented on HARMONY-3225:
-----------------------------------------
The last three patches: sub_ver_formatting.patch (690 kb), test.patch (15 kb), vf_interface.patch (2 kb) should be applied to the vm source tree.
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Attachment: sub_ver_1.patch
A patch updated.
Added possibility of managing verifier dumps via -Xtrace:verifier.dump.domain command line option.
Added more sensible pointer types instead of unsigned array indices.
Moved structures which are passed from upper level function to the lower level function using parameters to the verification context. Now they can be modified at any level. This is done in case when upper level functions do not actually access these parameters.
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482420 ]
Alexei Fedotov commented on HARMONY-3225:
-----------------------------------------
Patch notes:
1. The patch adds subroutine verification as it is described at http://wiki.apache.org/harmony/Subroutine_Verification
2. The VM with the patch is capable to pass Eclipse scenario.
3. A good portion of the patch is unification of naming conventions for types, prefixes and variables. Also, jvm instructions are referenced as instructions, not as code.
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3225) [drlvm][verifier] when jsr
instruction is the last, this produces verification error on parsing stage
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-3225:
------------------------------------
Patch Info: [Patch Available]
> [drlvm][verifier] when jsr instruction is the last, this produces verification error on parsing stage
> -----------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3225
> URL: https://issues.apache.org/jira/browse/HARMONY-3225
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Alexei Fedotov
> Attachments: format.sh, formatted.zip, interface.patch, LastJsrTest.patch, sub_ver.patch, sub_ver_1.patch, sub_ver_2.patch, sub_ver_formatting.patch, test.patch, vf_interface.patch
>
>
> The code checks the index of an instruction which follows jsr and founds that it is not in range.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.