You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Edward Sargisson <es...@pobox.com> on 2013/04/22 23:03:25 UTC
Review Request: FLUME-1992 ElasticSearch dependency is marked optional
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10709/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Added info to user guide as users will need to select which JAR they use.
Diffs
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205
Diff: https://reviews.apache.org/r/10709/diff/
Testing
-------
Thanks,
Edward Sargisson
Re: Review Request: FLUME-1992 ElasticSearch dependency is marked optional
Posted by Edward Sargisson <es...@pobox.com>.
> On April 22, 2013, 10:21 p.m., Israel Ekpo wrote:
> > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 1763
> > <https://reviews.apache.org/r/10709/diff/1/?file=283223#file283223line1763>
> >
> > I think you should a little bit more information to clarify which pom.xml they should examine.
> >
> > The client (ElasticSearchSink) has a pom file as well.
> >
> > So I think it would be better if we explicitly specify that the pom.xml to examine is that of the elasticsearch server cluster the sink is communicating with.
Thank you, Israel.
To my mind, I am happy with the wording as it stands as I do not see how a reader interpret the wording as looking in the pom.xml files in Flume itself.
- Edward
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10709/#review19551
-----------------------------------------------------------
On April 22, 2013, 9:03 p.m., Edward Sargisson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10709/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 9:03 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added info to user guide as users will need to select which JAR they use.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205
>
> Diff: https://reviews.apache.org/r/10709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Edward Sargisson
>
>
Re: Review Request: FLUME-1992 ElasticSearch dependency is marked optional
Posted by Israel Ekpo <is...@aicer.org>.
> On April 22, 2013, 10:21 p.m., Israel Ekpo wrote:
> > flume-ng-doc/sphinx/FlumeUserGuide.rst, line 1763
> > <https://reviews.apache.org/r/10709/diff/1/?file=283223#file283223line1763>
> >
> > I think you should a little bit more information to clarify which pom.xml they should examine.
> >
> > The client (ElasticSearchSink) has a pom file as well.
> >
> > So I think it would be better if we explicitly specify that the pom.xml to examine is that of the elasticsearch server cluster the sink is communicating with.
>
> Edward Sargisson wrote:
> Thank you, Israel.
> To my mind, I am happy with the wording as it stands as I do not see how a reader interpret the wording as looking in the pom.xml files in Flume itself.
Hi Edward,
I would like to clarify where this is coming from:
This is based on a previous question that was sent to me directly by a user (new to both Flume and ES) that had errors trying to start up a Flume agent with an elasticsearch sink
The user built Flume from source successfully.
Then the user ran mvn dependency:tree in this folder
https://git-wip-us.apache.org/repos/asf?p=flume.git;a=tree;f=flume-ng-sinks/flume-ng-elasticsearch-sink;hb=77b5d2885fecb3560a873bd89f49cbac8a010347
>From the output, the user determined what version of lucene and elasticsearch to use.
The user copied these Lucene and ES jars from ~/.m2/repository to $FLUME_HOME/lib
This resolved the ClassNotFoundException locally in Flume but the client was not compatible with the version of ElasticSearch at the service.
This folder also has a pom.xml file which is what led to the confusion in this instance.
To advanced users with a lot of experience with Flume and ES, this should never be an issue. It might sound like you are being too verbose.
However, to complete newbies to Flume and/or ES, there is a slight possibility for confusion as it was the case with this user.
- Israel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10709/#review19551
-----------------------------------------------------------
On April 22, 2013, 9:03 p.m., Edward Sargisson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10709/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 9:03 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added info to user guide as users will need to select which JAR they use.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205
>
> Diff: https://reviews.apache.org/r/10709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Edward Sargisson
>
>
Re: Review Request: FLUME-1992 ElasticSearch dependency is marked optional
Posted by Israel Ekpo <is...@aicer.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10709/#review19551
-----------------------------------------------------------
flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/10709/#comment40365>
I think you should a little bit more information to clarify which pom.xml they should examine.
The client (ElasticSearchSink) has a pom file as well.
So I think it would be better if we explicitly specify that the pom.xml to examine is that of the elasticsearch server cluster the sink is communicating with.
- Israel Ekpo
On April 22, 2013, 9:03 p.m., Edward Sargisson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10709/
> -----------------------------------------------------------
>
> (Updated April 22, 2013, 9:03 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added info to user guide as users will need to select which JAR they use.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst 38f2205
>
> Diff: https://reviews.apache.org/r/10709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Edward Sargisson
>
>